Feature: Allow pinning conversations to the top (XEP-0469)#3949
Open
mercihabam wants to merge 14 commits intoconversejs:masterfrom
Open
Feature: Allow pinning conversations to the top (XEP-0469)#3949mercihabam wants to merge 14 commits intoconversejs:masterfrom
mercihabam wants to merge 14 commits intoconversejs:masterfrom
Conversation
Author
|
Before adding tests for the many changes, I would appreciate a review from the maintainers. Thanks for taking the time to look into this! |
Author
|
I went ahead and added tests for the changes. Please review this when you get a chance. Thanks! |
Author
|
@jcbrand could you please take a look at this when you get the chance? Thanks. |
Member
|
@mercihabam Please rebase your PR onto the latest master branch. |
… on 'pinned' value change
mercihabam
force-pushed
the
bookmark-pinning
branch
from
5dcb28f to
c206ce6
Compare
Author
|
@jcbrand that is now done. |
Author
|
@jcbrand don't forget this one please. 😊 |
Member
|
I won't forget, but I'm first finishing off the emoji reactions and popular emojis work. Then I'll make a new release and then I'll get back to all the outstanding PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of #3509, which allows users to pin bookmarked MUC rooms to the top.
Here is a quick overview of how it looks:
