feat: require current password when resetting password#4099
Open
lequangsang01 wants to merge 1 commit into
Open
feat: require current password when resetting password#4099lequangsang01 wants to merge 1 commit into
lequangsang01 wants to merge 1 commit into
Conversation
This change adds a current password field to the password reset form, ensuring that users must provide their current password before they can set a new one. This prevents unauthorized password changes by anyone with access to the browser. Changes: - Added current_password input field to the password reset form - Updated the XMPP IQ stanza to include the old_password field - Added handling for not-authorized error (incorrect current password) - Updated existing tests and added new test for incorrect password case Fixes conversejs#3120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #3120 by adding a current password field to the password reset form. Currently, anyone with access to the browser can change the user's password without knowing the current one, which is a security concern.
Changes
<old_password>field when submitting the password change requestnot-authorizederror responses (shown when the current password is incorrect)Technical Details
The form now requires three fields:
When the form is submitted, the XMPP registration query includes both the new password and the old password, allowing the server to validate the current credentials before processing the change.
Related Issues