Exception handling?

[bquorning]

Thank you for this light-weight alternative to grpc. I hope to be able to use it in production soon.

But first I need to ask you about exception handling. I don’t see anything mentioned in the Readme, and I find no uses of rescue in the examples/ folder. But when trying this gem out, I ended up getting a lot of GrpcKit::Session::ClientSession::ConnectionClosing exceptions. I am not sure if they are caused by the client session becoming “too old”, or if the client has gotten itself into a bad state, or something else.

Any help (and/or documentation) would be appreciated.

[bquorning]

cc @sorah

[sorah]

according to the implementation ConnectionClosing is only raised when a Client received a GOAWAY frame.

[bquorning]

I wonder whether grpc_kit should open a new connection (or stream? I’m not 100% on the terminology) when a GOAWAY frame is received. Or should that be the responsibility of my own client code implementation?

[zenspider]

@sorah nudge

[sorah]

GrpcKit works as a building block and just receive an IO object as a a underlying connection, it is not possible to make new connection from GrpcKit directly. So the answer is yes.

[sorah]

Unrelated to your question itself, please note that grpc_kit's client-side implementation has a lot of issue like less-effecient IO. Personally I believe we need a huge overhaul of logics and API design, but we currently have no bandwidth to do that. Contributions are always welcomed.

(Cookpad uses server-side implementation with cookpad/griffin heavily, but for client-side we use official gRPC gem in most use cases)

[astrocket]

@sorah Do you have any hint for using cookpad/griffin & official gRPC client together?
eversince grpc_kit overides GRPC constant, they are conflicting each other.. For example, griffin server trying to call other rpc through official gRPC client.