Fix open issues: dehydration, reactivity, CSS, and tests#143
Merged
Conversation
Fix Pint violations, add coverage for range/multiple date dehydration, and harden workflows so styling runs on PRs, PHPStan runs on PRs, Pint gates the test matrix, and changelog updates open PRs instead of pushing to protected main. Co-authored-by: Cursor <cursoragent@cursor.com>
Address multiple/range/array dehydration, configurable range separators, locale arrays, time-only output, validation timing, Livewire state sync, cleared-field handling, slim flatpickr.css, and narrower production dependencies while expanding the dehydration test suite. Co-authored-by: Cursor <cursoragent@cursor.com>
Use a documented no-op body so empty-method formatting is consistent across Pint versions. Co-authored-by: Cursor <cursoragent@cursor.com>
Add gitattributes rules for PHP files and disable autocrlf on Windows runners so pint --test no longer fails with line_ending violations. Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
coolsam726
added a commit
that referenced
this pull request
Jun 13, 2026
#144) ## Summary - **#96** — Reactive `minDate`/`maxDate`: mirror Filament's `wire:key` + hidden constraint inputs so the picker re-inits when closures re-evaluate - **#129** — Modal loading: expand `x-load` triggers, add `IntersectionObserver`, and listen for modal open events before initializing Flatpickr - **#104** — Manual time entry: commit parsed values on `onClose` and input `blur` when `allowInput` or time picker is enabled - **#53** — Add `yearPicker()` with `Y` format and JS year extraction on change Also closes issues already fixed in #143 that remain open on GitHub: #100, #103, #122, #126, #128, #131, #133, #141, #130, #125, #119. **Out of scope:** #124 (Filament v3) — package targets Filament v4/v5 per README. ## Test plan - [x] `vendor/bin/pint --test` - [x] `vendor/bin/phpstan analyse` - [x] `vendor/bin/pest --ci` (19 tests) - [x] `npm run build` - [x] CI matrix passes - [ ] Manual QA: reactive min/max between two Flatpickr fields, modal create/edit form, manual time entry, year picker
This was referenced Jun 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #142 and tackles the highest-impact open GitHub issues with PHP fixes, JS reactivity improvements, CSS cleanup, dependency narrowing, and expanded tests.
Issues addressed
nullback to Livewire viaonChange/onClosehandlers$set()/ entangled state updates now re-sync the Flatpickr instance via Alpine$watchrangeSeparator()(defaults toto) for locale-specific range parsingH:iformat and dehydrates to time stringslocale()accepts arrays (e.g.firstDayOfWeek) passed through to Flatpickr JSsetUp()so rules run before dehydration@sourcescanning fromflatpickr.css; bundle shrank ~627KB → ~16KB and no longer hides the sidebar logo or bleeds table stylesfilament/forms+filament/support(filament/filamentkept in dev for tests/builds)Still open / follow-up
minDate/maxDatefrom PHP closures still need a Livewire-friendly attrs refresh strategy (wire:ignoreon the picker root limits re-rendering)onClose; needs browser QATest plan
vendor/bin/pint --testvendor/bin/phpstan analysevendor/bin/pest --ci(17 tests)npm run build$set()reactivity, clear-then-save, Spanish range separator, time picker manual entry