fix: remove unsafe exec() in call_qcsapi.c#13982
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
package/firmware/quantenna/src/call_qcsapi.c.Vulnerability
V-001package/firmware/quantenna/src/call_qcsapi.c:9681Description: Two unbounded strcpy() calls at lines 9681 and 9715 copy argv[0] directly into a fixed-size mac_addr buffer (typically 18 bytes for MAC format XX:XX:XX:XX:XX:XX) without any length validation. An attacker supplying a string longer than the destination buffer will overflow the stack frame, overwriting the saved return address and enabling arbitrary code execution. This is a textbook stack buffer overflow with no mitigating controls evident in the code.
Changes
package/firmware/quantenna/src/call_qcsapi.cVerification
Automated security fix by OrbisAI Security