Introduce PlaceTypeBuilder to simplify PlaceType construction#2
Merged
Conversation
5996109 to
dc61d95
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a PlaceTypeBuilder to streamline the construction of PlaceType and Assumption objects. The builder pattern helps manage existential variable indices properly when combining multiple PlaceTypes and RefinedTypes into a single one.
Key changes:
- Introduces
PlaceTypeBuilderwith methods for subsuming types and managing formulas - Refactors existing
PlaceTypemethods to use the builder pattern - Simplifies code in multiple locations by replacing manual existential variable management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/refine/env.rs | Adds PlaceTypeBuilder struct and refactors PlaceType methods to use it |
| src/refine.rs | Exports the new PlaceTypeBuilder |
| src/analyze/basic_block.rs | Updates code to use PlaceTypeBuilder instead of deprecated PlaceType methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
coeff-aij
pushed a commit
to coeff-aij/thrust
that referenced
this pull request
Jan 12, 2026
Introduce PlaceTypeBuilder to simplify PlaceType construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is also used to construct Assumption; I couldn't come up with a better name.