Handle parens in annotations properly#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables proper handling of parentheses in logical formula annotations by restructuring the parser to support both formulas and terms in a unified parsing approach.
- Introduces a unified
FormulaOrTermenum that can represent either formulas or terms with ambiguous binary operations - Refactors the parser to use operator precedence parsing with separate precedence levels for different operators
- Adds support for parentheses in logical expressions by allowing formulas and terms to be parsed within parenthetical expressions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/ui/pass/annot.rs | Adds test case demonstrating parentheses usage in logical formula annotations |
| tests/ui/fail/annot.rs | Adds test case showing invalid formula that should fail verification |
| src/annot.rs | Major parser refactoring to support unified formula/term parsing with proper precedence handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
coeff-aij
pushed a commit
to coeff-aij/thrust
that referenced
this pull request
Jan 12, 2026
Handle parens in annotations properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables usage of parenthesis in logical formula annotations