Skip to content

Commit 2adfd4b

Browse files
krukowCopilot
andcommitted
fix: address Copilot Code Review feedback
- Use cond-> to only assoc optional context fields when non-nil - Update resume-session docstring to match create-session Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent cf9ece9 commit 2adfd4b

1 file changed

Lines changed: 10 additions & 7 deletions

File tree

src/github/copilot_sdk/client.clj

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -364,12 +364,12 @@
364364
(when request-id
365365
(go
366366
(try
367-
(let [context {:session-id session-id
368-
:message (:message data)
369-
:requested-schema (:requested-schema data)
370-
:mode (:mode data)
371-
:elicitation-source (:elicitation-source data)
372-
:url (:url data)}
367+
(let [context (cond-> {:session-id session-id
368+
:message (:message data)}
369+
(some? (:requested-schema data)) (assoc :requested-schema (:requested-schema data))
370+
(some? (:mode data)) (assoc :mode (:mode data))
371+
(some? (:elicitation-source data)) (assoc :elicitation-source (:elicitation-source data))
372+
(some? (:url data)) (assoc :url (:url data)))
373373
result (<! (session/handle-elicitation-request! client session-id context))]
374374
(when result
375375
(let [conn (:connection-io @(:state client))]
@@ -1501,7 +1501,10 @@
15011501
- :infinite-sessions - Infinite session configuration
15021502
- :reasoning-effort - Reasoning effort level: \"low\", \"medium\", \"high\", or \"xhigh\"
15031503
- :on-user-input-request - Handler for ask_user requests
1504-
- :on-elicitation-request - Handler for elicitation requests (upstream PR #908)
1504+
- :on-elicitation-request - Handler for elicitation requests (upstream PRs #908, #960).
1505+
Single-arg handler receives an ElicitationContext map with
1506+
:session-id, :message, :requested-schema, :mode,
1507+
:elicitation-source, :url. Returns an ElicitationResult map.
15051508
- :hooks - Lifecycle hooks map
15061509
- :on-event - Event handler (1-arg fn) registered before the RPC call.
15071510
Guarantees early events like session.start are not missed.

0 commit comments

Comments
 (0)