Skip to content

Commit c414af2

Browse files
krukowCopilot
andcommitted
Address Copilot Code Review round 3
- Fix mock stub for session.ui.elicitation: return elicitation result shape ({:action :content}) instead of nested {:result {}} - Fix changelog: update test count from 13 to 18 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 95e4b55 commit c414af2

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ All notable changes to this project will be documented in this file. This change
1616
- **User input handler tests** — 2 tests for `userInput.request` server→client RPC
1717
- **System message transform tests** — 3 tests for `systemMessage.transform` callback invocation, error fallback, and passthrough
1818
- **Tool result normalization tests** — 3 tests for string, nil, and structured ToolResultObject results via v3 broadcast
19-
- **Session RPC wrapper tests**13 integration tests for all new RPC wrapper functions
19+
- **Session RPC wrapper tests**18 integration tests for all new RPC wrapper functions
2020
- **Mock server enhancements**`send-rpc-request!` for testing server→client RPCs, response routing in server loop, 30+ new method stubs
2121
- Full `s/fdef` instrumentation for all 19 new public functions
2222

src/github/copilot_sdk/session.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1268,7 +1268,7 @@
12681268
conn (connection-io client)]
12691269
(util/wire->clj
12701270
(proto/send-request! conn "session.fleet.start"
1271-
(merge {:session-id session-id} params)))))
1271+
(assoc (merge {} params) :session-id session-id)))))
12721272

12731273
;; -- UI Elicitation ----------------------------------------------------------
12741274

test/github/copilot_sdk/mock_server.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@
348348
"session.compaction.compact" {:success true}
349349
"session.shell.exec" {:exitCode 0 :stdout "" :stderr ""}
350350
"session.shell.kill" {:success true}
351-
"session.ui.elicitation" {:result {}}
351+
"session.ui.elicitation" {:action "accept" :content {}}
352352
"mcp.config.list" {:servers []}
353353
"mcp.config.add" {:success true}
354354
"mcp.config.update" {:success true}

0 commit comments

Comments
 (0)