You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Always implement changes and create PR, don't stop at issue
Update workflow prompt to instruct the agent to always proceed with
implementation after analysis. Issues are used as tracking items that
the PR closes (via 'Closes #NN'), not as alternatives to implementation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy file name to clipboardExpand all lines: .github/workflows/upstream-sync.md
+11-9Lines changed: 11 additions & 9 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -202,21 +202,24 @@ Before creating the PR, review your own changes:
202
202
203
203
### Phase 7: Create the PR
204
204
205
-
Create a pull request with:
205
+
First, if the change is complex or warrants discussion, create a **tracking issue** describing:
206
+
- The upstream changes being ported
207
+
- Your analysis and implementation approach
208
+
- Any design decisions or trade-offs
209
+
210
+
Then **always proceed to implement and create a pull request**. Do not stop at the issue.
211
+
212
+
Create the pull request with:
206
213
207
214
-**Title**: `[upstream-sync] Port changes from copilot-sdk vX.Y.Z` (or specific PR titles if only a few)
208
215
-**Body** including:
216
+
-`Closes #NN` (referencing the tracking issue, if one was created) so the issue auto-closes on merge
209
217
- Summary of upstream changes ported
210
218
- List of upstream PRs referenced (with links)
211
219
- Changes skipped and why
212
220
- Testing performed
213
221
- Any notes for the reviewer
214
222
215
-
If the changes are too complex or ambiguous to implement confidently, create an **issue** instead of a PR, describing:
216
-
- The upstream changes that need attention
217
-
- Why automated porting was not feasible
218
-
- Suggested approach for manual implementation
219
-
220
223
### Phase 8: Update Cache
221
224
222
225
After creating the PR (or noop/issue), update cache-memory with:
@@ -226,14 +229,13 @@ After creating the PR (or noop/issue), update cache-memory with:
226
229
227
230
## Guidelines
228
231
229
-
-**Be conservative**: When in doubt, create an issue for human review rather than making a risky change.
232
+
-**Always implement**: Do not stop at creating an issue. Always proceed to implement the changes and create a PR. Use issues as tracking items that the PR closes, not as alternatives to implementation.
230
233
-**Small PRs**: If there are many upstream changes, prefer creating one focused PR per logical change rather than one massive PR.
231
234
-**Respect the design philosophy**: This is an idiomatic Clojure library, not a line-by-line translation.
232
235
-**Wire format matters**: Protocol/wire code must match upstream exactly. Clojure idioms apply to the API surface, not the wire format.
233
236
-**Version sync**: If upstream has a new release version, note it but do NOT bump versions — that's done by the maintainer.
234
237
235
238
## Safe Outputs
236
239
237
-
-**If changes were ported**: Use `create-pull-request` with the implementation branch.
238
-
-**If changes need human review**: Use `create-issue` describing what needs attention.
240
+
-**If changes were ported**: Use `create-issue` first (if helpful for tracking), then `create-pull-request` with `Closes #NN` in the body.
239
241
-**If no relevant changes found**: Call `noop` with a message like "No upstream changes require porting since last sync on YYYY-MM-DD."
0 commit comments