fix(passkeys_doctor): widen device_info_plus constraint to allow ^12.0.0#238
Open
M0n7y5 wants to merge 1 commit intocorbado:mainfrom
Open
fix(passkeys_doctor): widen device_info_plus constraint to allow ^12.0.0#238M0n7y5 wants to merge 1 commit intocorbado:mainfrom
M0n7y5 wants to merge 1 commit intocorbado:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
device_info_plusconstraint inpasskeys_doctoris currently pinned to^11.2.0, which prevents any project that also uses a package requiringdevice_info_plus ^12.0.0from upgradingpasskeyspast 2.8.2.In my case
livekit_clientneedsdevice_info_plus ^12.3.0, but any package depending ondevice_info_plus 12.xwould hit the same wall.The only usage of
device_info_plusinpasskeys_doctorisDeviceInfoPlugin().iosInfo, which hasn't changed between v11 and v12, so widening the constraint to>=11.2.0 <13.0.0should be safe.