Skip to content

Commit e005bf7

Browse files
committed
Refactor error handling in AppendProcessProvider to include message codes. Update ConnectService to accept message codes in recordEventAppendError method.
1 parent 2f70f2f commit e005bf7

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

packages/connect-react/src/contexts/AppendProcessProvider.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,11 @@ export const AppendProcessProvider: FC<PropsWithChildren<Props>> = ({ children,
2929

3030
const handleErrorSoft = useCallback(
3131
async (situationCode: AppendSituationCode, expected: boolean, showError: boolean, error?: ConnectError) => {
32+
const messageCode = `situation: ${situationCode} ${error?.track()}`;
3233
if (expected) {
33-
await getConnectService().recordEventAppendError();
34+
await getConnectService().recordEventAppendError(messageCode);
3435
} else {
35-
await getConnectService().recordEventAppendErrorUnexpected(`situation: ${situationCode} ${error?.track()}`);
36+
await getConnectService().recordEventAppendErrorUnexpected(messageCode);
3637
}
3738

3839
if (showError) {
@@ -44,10 +45,11 @@ export const AppendProcessProvider: FC<PropsWithChildren<Props>> = ({ children,
4445

4546
const handleErrorHard = useCallback(
4647
async (situationCode: AppendSituationCode, expected: boolean, error?: ConnectError) => {
48+
const messageCode = `situation: ${situationCode} ${error?.track()}`;
4749
if (expected) {
48-
await getConnectService().recordEventAppendError();
50+
await getConnectService().recordEventAppendError(messageCode);
4951
} else {
50-
await getConnectService().recordEventAppendErrorUnexpected(`situation: ${situationCode} ${error?.track()}`);
52+
await getConnectService().recordEventAppendErrorUnexpected(messageCode);
5153
}
5254

5355
config.onError?.(situationCode.toString());

packages/web-core/src/services/ConnectService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,8 @@ export class ConnectService {
660660
return this.#recordEvent(PasskeyEventType.AppendCredentialExists, messageCode, challenge);
661661
}
662662

663-
recordEventAppendError() {
664-
return this.#recordEvent(PasskeyEventType.AppendError);
663+
recordEventAppendError(messageCode?: string) {
664+
return this.#recordEvent(PasskeyEventType.AppendError, messageCode);
665665
}
666666

667667
recordEventLoginErrorUnexpected(messageCode: string) {

0 commit comments

Comments
 (0)