Add message to expected append-error for web to collect messages#597
Merged
incorbador merged 1 commit intodevelopfrom Mar 12, 2026
Merged
Add message to expected append-error for web to collect messages#597incorbador merged 1 commit intodevelopfrom
message to expected append-error for web to collect messages#597incorbador merged 1 commit intodevelopfrom
Conversation
…odes. Update ConnectService to accept message codes in recordEventAppendError method.
Contributor
Author
message to expected ppend-error
message to expected ppend-errormessage to expected append-error
message to expected append-errormessage to expected append-error for web to collect messages
Contributor
Author
|
Before patch:
After patch:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Expected append errors (
append-errorevents) were missing themessageCodeentirely — 12,252 events had NULL messages. This aligns the web SDK withcorbado-iosandcorbado-android, which always include situation + error details for both expected and unexpected errors.Cross-SDK comparison (before/after)
Changes