Ensure RFFT spectrum is always positive#26
Closed
dy wants to merge 1 commit into
Closed
Conversation
Author
|
@corbanbrook is there anything on that? |
|
Hi @dfcreative I'm learning dsp and, since this library is now unmaintained, building my own dsp library taking parts from different projects. I would like to adopt rfft as the default FFT method (because of performance) but I found several issues. Take a look my comments to: #5 Maybe you can give me some clues about that... Thanks! |
Author
|
@corbanbrook is there any chance it will be merged? If no, I suggest closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @corbanbrook!
The RFFT forward transform sometimes exhibits negative spectrum value for a static item.
That is because of not really measuring the length of phasor as in the loop above, but supposition that zero frequency has positive value, which is not always true.
e.g.
gives