Use published bootc-internal-{utils,blockdev} crates#963
Conversation
c00976d to
57b4e4c
Compare
|
Thank you @cgwalters for the workaround, not sure if my understanding is correct, in this case, the dependencies |
|
Ah right, thanks for testing this out. Yeah I think we're hitting a really longstanding Rust toolchain limitation that requires publishing these sub-crates when what we really want is for them to just be automatically vendored. I think this PR would need to be reworked to instead rework the sub-crates as modules (very unfortunate ergonomic hit). xref e.g. https://www.reddit.com/r/rust/comments/10k4q0c/rust_2030_christmas_list_subcrate_dependencies/ |
|
OK I hacked this up to use modules instead (it's ugly) and it at least compiles locally, but for some reason No idea about that right now |
See coreos/bootupd#963 Basically I just want a way to keep these in sync with bootupd; we're not attempting to make a truly public library. Signed-off-by: Colin Walters <walters@verbum.org>
|
Man it's just so unreasonably difficult to share these little bits of code between two projects without going all the way to publishing as a stable crate, which has a pretty high overhead for what it would give us (especially in making a separate RPM package for it!). Anyways, I now did bootc-dev/bootc#1394 What I always find really ironic about this from the distro side is that there are no alarms about duplicate code that no one is actively trying to keep in sync. |
This remains the best available solution. |
For now we'll continue to publish bootupd as a crate, but I think we should eventually stop doing this. Closes: coreos#964
d15648a to
12e91ec
Compare
|
Thank you @cgwalters for fixing the issue. |
For now we'll continue to publish bootupd as a crate,
but I think we should eventually stop doing this.
Closes: #964