Commit db1f6a7
committed
kola: Force
Part of my war against duplicative comments in our kola tests.
We have a few tests that write a comment like this:
```
# - exclusive: false
# - This test doesn't make meaningful changes to the system and
# should be able to be combined with other tests.
```
Of course, this comment is already redundant because the
meaning of the `exclusive` tag is defined canonically in coreos-assembler
(here) and copy-pasting that into every test that uses it would
be pointlessly verbose.
But - we can do one better. Instead of having this flag be an
"I promise not to mutate the system" field, we can *enforce* it.
Then it doesn't need to be commented - if someone later tries
to change an `exclusive: false` test to mutate things, the test
will *fail*. The behavior is hence more self-documenting and
enforcing.
Some tests need adjustment for this.exclusive: false tests to use ProtectSystem=strict
1 parent 3991e6f commit db1f6a7
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
980 | 980 | | |
981 | 981 | | |
982 | 982 | | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
983 | 989 | | |
984 | 990 | | |
985 | 991 | | |
| |||
0 commit comments