kola/tests/iso: add CheckLiveArtifactsExist helper function for ISO tests

Add helper function in common.go to validate presence of live artifacts.

Author: nikita-dubrovskii

mantle/kola/tests/iso/common.go

@@ -130,6 +130,13 @@ func getIsoTestOpts(testName string) IsoTestOpts {
 	return opts
 }
 
+func CheckLiveArtifactsExist() error {
+	if kola.CosaBuild.Meta.BuildArtifacts.LiveIso == nil || kola.CosaBuild.Meta.BuildArtifacts.LiveKernel == nil || kola.CosaBuild.Meta.BuildArtifacts.LiveInitramfs == nil || kola.CosaBuild.Meta.BuildArtifacts.LiveRootfs == nil {
+		return fmt.Errorf("Build %s is missing live artifacts\n", kola.CosaBuild.Meta.Name)
+	}
+	return nil
+}
+
 func IsDevBuild() bool {
 	// Ignore signing verification by default when running with development build
 	// https://github.com/coreos/fedora-coreos-tracker/issues/908

mantle/kola/tests/iso/live-as-disk.go

@@ -44,6 +44,9 @@ func init() {
 }
 
 func isoTestAsDisk(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := CheckLiveArtifactsExist(); err != nil {
+		c.Fatal(err)
+	}
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")

mantle/kola/tests/iso/live-fips.go

@@ -51,6 +51,9 @@ ExecStart=grep FIPS etc/crypto-policies/config
 RequiredBy=fips-signal-ok.service`
 
 func testLiveFIPS(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := CheckLiveArtifactsExist(); err != nil {
+		c.Fatal(err)
+	}
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")

mantle/kola/tests/iso/live-iscsi.go

@@ -106,6 +106,9 @@ var iscsi_butane_config string
 //   - when the system is booted, write a success string to /dev/virtio-ports/testisocompletion
 //   - as this serial device is mapped to the host serial device, the test concludes
 func isoInstalliScsi(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := CheckLiveArtifactsExist(); err != nil {
+		c.Fatal(err)
+	}
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")

mantle/kola/tests/iso/live-iso.go

@@ -100,6 +100,9 @@ func init() {
 }
 
 func runLiveIsoInstallTest(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := CheckLiveArtifactsExist(); err != nil {
+		c.Fatal(err)
+	}
 	if opts.isMiniso && opts.isOffline { // ideally this'd be one enum parameter
 		c.Fatal("Can't run minimal install offline")
 	}

mantle/kola/tests/iso/live-login.go

@@ -71,10 +71,9 @@ func init() {
 }
 
 func testLiveLogin(c cluster.TestCluster, firmware string) {
-	if kola.CosaBuild.Meta.BuildArtifacts.LiveIso == nil || kola.CosaBuild.Meta.BuildArtifacts.LiveKernel == nil {
-		c.Fatalf("Build %s is missing live artifacts\n", kola.CosaBuild.Meta.Name)
+	if err := CheckLiveArtifactsExist(); err != nil {
+		c.Fatal(err)
 	}
-
 	butane := conf.Butane(`
 variant: fcos
 version: 1.1.0`)

mantle/kola/tests/iso/live-pxe.go

@@ -94,6 +94,9 @@ RequiredBy=coreos-installer.target
 `
 
 func testPXE(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := CheckLiveArtifactsExist(); err != nil {
+		c.Fatal(err)
+	}
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")