Skip to content

kola: add support for tests with Secure Boot enabled#4114

Merged
PeaceRebel merged 1 commit into
coreos:mainfrom
PeaceRebel:kola-tag-sb
May 30, 2025
Merged

kola: add support for tests with Secure Boot enabled#4114
PeaceRebel merged 1 commit into
coreos:mainfrom
PeaceRebel:kola-tag-sb

Conversation

@PeaceRebel

@PeaceRebel PeaceRebel commented May 27, 2025

Copy link
Copy Markdown
Contributor

Add a new kola tag to configure qemu with Secure Boot enabled

Fixes: #4112
Needed for: coreos/fedora-coreos-config#3326

@PeaceRebel PeaceRebel self-assigned this May 27, 2025
travier
travier previously approved these changes May 27, 2025

@travier travier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can bikeshed on the name but should be fine.

Comment thread mantle/kola/harness.go Outdated
travier
travier previously approved these changes May 28, 2025
jbtrystram
jbtrystram previously approved these changes May 28, 2025

@jbtrystram jbtrystram left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeaceRebel PeaceRebel dismissed stale reviews from jbtrystram and travier via a85efe9 May 28, 2025 15:43
@HuijingHei

Copy link
Copy Markdown
Contributor

LGTM, I am OK starting with qemu platform, and add other platform later.

@PeaceRebel PeaceRebel requested review from jbtrystram and travier May 29, 2025 14:18
Add a new kola tag to configure qemu with Secure Boot enabled

Fixes: coreos#4112

@HuijingHei HuijingHei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c4rt0 c4rt0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PeaceRebel PeaceRebel merged commit bf6319e into coreos:main May 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add kola tag to run test with Secure Boot enabled

5 participants