Skip to content

kola/azure: correct default vm size #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustymabe merged 1 commit into from
May 30, 2025
Merged

kola/azure: correct default vm size #4120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/kola.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ In order to see the logs for these tests you must enter the `tmp/kola/name_of_th
- `gcp-json-key` is using a service account's JSON key for authentication, how to create service account keys refer to https://github.com/coreos/coreos-assembler/blob/main/docs/mantle/credentials.md#gcp.
- `gcp-project` is meant for testing in the specified project, or it will use the same as `<GCP Image Project>`.

`cosa kola run --arch=x86_64 -p=azure --azure-credentials azureCreds.json --azure-disk-uri ${ImageId} basic` This will run the basic tests on Azure using default machine type `Standard_D2_v3`.
`cosa kola run --arch=x86_64 -p=azure --azure-credentials azureCreds.json --azure-disk-uri ${ImageId} basic` This will run the basic tests on Azure using default machine type `Standard_D2s_v3`.
- `azure-credentials` is a JSON file generated by hand to pass authentication to our mantle code that will then use it to authenticate with azure services, how to create credentials refer to https://github.com/coreos/coreos-assembler/blob/main/docs/mantle/credentials.md#azure
- `azure-disk-uri` is Azure disk uri of the custom image, this could be a gallery image version if you are using Azure Compute Gallery, refer to https://learn.microsoft.com/en-us/azure/virtual-machines/azure-compute-gallery. For example, get gallery image id via command: `galleryImageId=$(az sig image-version show --gallery-image-definition "${gallery_image_definition}" --gallery-image-version "${gallery_image_version}" --gallery-name "${gallery_name}" --resource-group $az_resource_group | jq -r .id)`.
- `azure-location` specifies Azure location if you want to use custom location, by default is `westus`.
- `azure-size` specifies Azure machine size if you want to use custom size, by default is `Standard_D2_v3`.
- `azure-size` specifies Azure machine size if you want to use custom size, by default is `Standard_D2s_v3`.
2 changes: 1 addition & 1 deletion mantle/cmd/kola/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func init() {
sv(&kola.AzureOptions.Sku, "azure-sku", "alpha", "Azure image sku/channel (default \"alpha\"")
sv(&kola.AzureOptions.Version, "azure-version", "", "Azure image version")
sv(&kola.AzureOptions.Location, "azure-location", "westus", "Azure location (default \"westus\"")
sv(&kola.AzureOptions.Size, "azure-size", "Standard_D2_v3", "Azure machine size (default \"Standard_D2_v3\")")
sv(&kola.AzureOptions.Size, "azure-size", "Standard_D2s_v3", "Azure machine size (default \"Standard_D2s_v3\")")
sv(&kola.AzureOptions.AvailabilityZone, "azure-availability-zone", "1", "Azure Availability Zone (default \"1\")")

// do-specific options
Expand Down
Loading