qemu: Handle RHEL#4121
Closed
cgwalters wants to merge 1 commit into
Closed
Conversation
I know that coreos-assembler is always based on Fedora today; we had a long ago effort to base it on RHEL which I think may still make sense at some point. Anyways though I still sometimes install cosa inside my toolbox because it can be more convenient. This change adds support for RHEL, there's two parts: - In the case where target arch == host arch, just run qemu-kvm; in fact on RHEL that's the only supported thing by default, full emulation is not enabled - Also we need /usr/libexec because libvirt is the primary interface
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dustymabe
reviewed
Jun 2, 2025
| } | ||
| // This is hidden on RHEL as libvirt is the primary interface | ||
| if _, err := os.Stat(binary); err != nil && os.IsNotExist(err) { | ||
| binary = "/usr/libexec/qemu-kvm" |
Member
There was a problem hiding this comment.
Is this stored at /usr/libexec/qemu-kvm for every architecture?
Member
|
Just spot checking a COSA container on an aarch64 host: |
Member
Author
|
Yeah sorry, I didn't test on Fedora. It's probably not worth the churn of trying this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that coreos-assembler is always based on Fedora today; we had a long ago effort to base it on RHEL which I think may still make sense at some point.
Anyways though I still sometimes install cosa inside my toolbox because it can be more convenient.
This change adds support for RHEL, there's two parts: