cmd-remote-build-container: add --add-openshift-build-labels#4124
Merged
Conversation
Currently, `oc` looks for non-standard labels for git information, which
it then places in e.g. `image-references` in the release payload.
Ideally `oc` would also check for the standard
`org.opencontainers.image.{revision,source}` labels too for this purpose
but this assumption is wired in a bunch of places so let's just conform
for now to it.
Add a new option to inject these labels. This can then be used when
building the node image extensions image. In turn, this makes the
release controller page for a release have working links for our images
to the openshift/os commit they were built from, just like the other
images.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Jun 2, 2025
This will fix a small UX issue in the release controller: it will add working links for our images to the openshift/os commit they were built from, just like the other images. See also coreos/coreos-assembler#4124 which this requires.
jlebon
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Jun 5, 2025
This will fix a small UX issue in the release controller: it will add working links for our images to the openshift/os commit they were built from, just like the other images. See also coreos/coreos-assembler#4124 which this requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
oclooks for non-standard labels for git information, which it then places in e.g.image-referencesin the release payload.Ideally
ocwould also check for the standardorg.opencontainers.image.{revision,source}labels too for this purpose but this assumption is wired in a bunch of places so let's just conform for now to it.Add a new option to inject these labels. This can then be used when building the node image extensions image. In turn, this makes the release controller page for a release have working links for our images to the openshift/os commit they were built from, just like the other images.