Skip to content

test/targetcli: switch to Fedora OS as base layer#4132

Merged
jlebon merged 1 commit into
coreos:mainfrom
joelcapitao:switch-to-fedora-base-layer
Jun 11, 2025
Merged

test/targetcli: switch to Fedora OS as base layer#4132
jlebon merged 1 commit into
coreos:mainfrom
joelcapitao:switch-to-fedora-base-layer

Conversation

@joelcapitao
Copy link
Copy Markdown
Member

For consistency and simplicity, let's move to Fedora as base layer. This will simplify the onboarding to Konflux.

jlebon
jlebon previously approved these changes Jun 5, 2025
Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume we verified that the iSCSI tests still pass with this?

Comment thread tests/containers/targetcli/Containerfile Outdated
For consistency and simplicity, let's move to Fedora as base layer.
This will simplify the onboarding to Konflux.
@joelcapitao
Copy link
Copy Markdown
Member Author

LGTM. I assume we verified that the iSCSI tests still pass with this?

yes, I ran locally the kola tests iso-offline-install-iscsi.* and they pass

@jlebon jlebon enabled auto-merge (rebase) June 11, 2025 13:10
@joelcapitao
Copy link
Copy Markdown
Member Author

/override ci/prow/rhcos
as it's failing on coreos/rhel-coreos-config#20.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 11, 2025

@jcapiitao: Overrode contexts on behalf of jcapiitao: ci/prow/rhcos

Details

In response to this:

/override ci/prow/rhcos
as it's failing on coreos/rhel-coreos-config#20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jlebon jlebon merged commit 236e7de into coreos:main Jun 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants