Add bootupd option bios.device#4161
Closed
HuijingHei wants to merge 1 commit into
Closed
Conversation
Because of the change coreos/bootupd@f6ef3d1 in new bootupd-0.2.28, we use `sfdisk` to find esp part, so we need to pass the target device. Fix live build error when running: ``` $ cosa osbuild metal metal4k live ... org.osbuild.bootupd: ed39b5197b7c952249a72fff63355163dae556a95eb000b3bb1d2ae72cb5b3f1 { "static-configs": true, "deployment": { "default": true } } Skip installing component BIOS without target device error: boot data installation failed: installing component EFI: Listing partitions of : Subprocess failed: ExitStatus(unix_wait_status(256)) sfdisk: cannot open : No such file or directory ... subprocess.CalledProcessError: Command '['chroot', '/run/osbuild /mounts/ostree/deploy/fedora-coreos/deploy/xx', '/usr/bin/bootupctl', 'backend', 'install', '--with-static-configs', '/run/osbuild/mounts']' returned non-zero exit status 1. ```
Contributor
Author
|
Refer to the error log in https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/blue/organizations/jenkins/test-override/detail/test-override/1803/pipeline/196/ when using @dustymabe do you happen to know that when building live image, is it intended to skip BIOS by default? See [testing][x86_64] 42.20250623.2.0 |
dustymabe
reviewed
Jun 24, 2025
| - type: org.osbuild.bootupd | ||
| options: | ||
| bios: | ||
| device: disk |
Member
There was a problem hiding this comment.
The change you are making here is for the 4k disk images we produce. When booting a system with a 4k disk BIOS isn't an option, so I don't recommend making this change.
Contributor
Author
There was a problem hiding this comment.
Thank you for the confirmation, then will make bootupd changed to detect the mounted efi first? WDYT?
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Jun 24, 2025
When building a live image without a device (e.g., metal4k), a mounted directory will be used to continue the process. See coreos/coreos-assembler#4161
Contributor
Author
|
Close this according to #4161 (comment), will workaround this in bootupd coreos/bootupd#960 |
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Jun 24, 2025
When building a live image without a device (e.g., metal4k), a mounted directory will be used to continue the process. See coreos/coreos-assembler#4161
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Jun 25, 2025
Let's attempt to use an already mounted ESP at the target dest_root if one is already mounted there in a known ESP location, if failed, will fallback to mount ESP partition of the device. See coreos/coreos-assembler#4161
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Jun 25, 2025
Let's attempt to use an already mounted ESP at the target dest_root if one is already mounted there in a known ESP location, if failed, will fallback to mount ESP partition of the device. See coreos/coreos-assembler#4161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the change coreos/bootupd@f6ef3d1 in new bootupd-0.2.28, we use
sfdiskto find esp part, so we need to pass the target device.Fix live build error when running: