-
Notifications
You must be signed in to change notification settings - Fork 190
fold 'kola testiso' into 'kola run' #4377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikita-dubrovskii
wants to merge
31
commits into
coreos:main
Choose a base branch
from
nikita-dubrovskii:fold_testiso
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
30731cb
mantle/platform/qemu: add MachineBuilder for customizable machine cre…
nikita-dubrovskii 0158cb8
kola/tests/iso: fold testiso live-login.* tests into 'kola run'
nikita-dubrovskii 417e0ac
mantle/platform: move metal.go to machine/qemu/
nikita-dubrovskii d87650e
mantle/platform/machine/qemu: merge InstalledMachine into machine struct
nikita-dubrovskii bfa8b0d
kola/tests/iso: fold testiso (iso|miniso)-(offline-)?install* tests
nikita-dubrovskii 1f5c97c
kola/tests/iso: fold testiso *pxe* tests
nikita-dubrovskii 5ebdd5e
kola/tests/iso: fold testiso *iscsi* tests
nikita-dubrovskii 8059f59
kola/tests/iso: fold testiso iso-as-disk tests
nikita-dubrovskii 548e343
kola/tests/iso: refactor live-iso.go into independent test files
nikita-dubrovskii c9a7fb4
kola/tests/iso: Dump journal on emergency.target in ISO tests
nikita-dubrovskii c50d43f
mantle/cmd/kola: move inst-insecure and pxe-kargs to global QEMUOptions
nikita-dubrovskii 6d4d394
kola/tests/iso: fold testiso iso-fips.uefi test
nikita-dubrovskii 4298660
kola/tests/iso: extract CheckTestOutput helper function
nikita-dubrovskii 4f2092c
kola/tests/iso: remove redundant console and journal checks
nikita-dubrovskii 65b2d62
kola/tests/iso: refactor *fips* tests
nikita-dubrovskii c437fb4
kola/tests/iso: refactor *iscsi* tests
nikita-dubrovskii 98c7cef
kola/tests/iso: refactor iso-as-disk* tests
nikita-dubrovskii c939c2c
mantle/qemu: conditionally wait for SSH address
nikita-dubrovskii 3dd9de6
mantle/qemu: add Instance() method to access QemuInstance
nikita-dubrovskii ea32701
kola/tests/iso: refactor (iso|miniso)-(offline-)?install* tests
nikita-dubrovskii 0b530b3
mantle/platform: Add IgnitionPath() helper to QemuBuilder
nikita-dubrovskii a4f85b7
mantle/platform: Allow passing nil instead of Ignition config
nikita-dubrovskii eba33e3
kola/tests/iso: refactor *pxe* tests
nikita-dubrovskii 8e60899
mantle/platform/machine/qemu: drop no longer used code
nikita-dubrovskii 95a660f
mantle/kola/tests/iso: Use firmware string instead of booleans
nikita-dubrovskii 101c908
mantle/kola/tests/iso: Remove obsolete console field from IsoTestOpts
nikita-dubrovskii 86a0595
mantle/platform/qemu: add setter for netdev's bootindex property
nikita-dubrovskii 85b71ba
kola/tests/iso: simplify iso.pxe* networking initialization
nikita-dubrovskii 779c267
kola/tests/iso: add CheckLiveArtifactsExist helper function for ISO t…
nikita-dubrovskii 36269c0
kola/tests/iso: align test function names to testLive* pattern
nikita-dubrovskii e5b1db5
cmd-kola: add testiso to run iso.* translation wrapper
nikita-dubrovskii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment 'kola run iso.* options' is redundant and adds noise to the init function. It is better to rely on the grouping of related flags.