{kola,kolaTestIso}: workaround issue with accessDenied from dir()#124
Merged
Conversation
dustymabe
force-pushed
the
dusty-add-cd
branch
from
e8d805d to
f3e1d44
Compare
dustymabe
requested review from
gursewak1997,
jlebon,
mike-nguyen,
ravanelli and
saqibali-2k
as code owners
jlebon
approved these changes
Oct 17, 2022
jlebon
left a comment
jlebon
left a comment
Member
There was a problem hiding this comment.
LGTM! As discussed OOB, we will circle back on this and rework things to make it cleaner.
When using dir() in the kola and kolaTestIso jobs the cd is happening on the controller (not in the COSA pod).
To clarify, that was my first theory but in testing, the fact that it does work if it's a subdir of the workspace seems to indicate it's more subtle than that.
When using `dir()` in the kola and kolaTestIso jobs we are getting a
permission denied error if the directory is isn't under the env.WORKSPACE
directory.
Let's go back to using a `cd ${cosaDir}` for now to workaround this while
we find better solutions. This `cd ${cosaDir}` will have no effect on
multi-arch where we'll be operating in a remote session anyway.
dustymabe
force-pushed
the
dusty-add-cd
branch
from
f3e1d44 to
ade91b6
Compare
Member
Author
updated the commit message to drop that possibly inaccurate detail. |
jlebon
added a commit
to jlebon/coreos-ci-lib
that referenced
this pull request
Oct 17, 2022
Support for the cosa directory being different from the working
directory makes implementation details messier.
Drop support for it.
Callers can still have their cosa directories be different from the
Jenkins workspace by first wrapping calls to the cosa APIs here in a
call to `dir(cosaDir)`:
```
dir(cosaDir) {
cosaBuild(skipKola: true)
kola()
kolaTestIso(skipMetal4k: true)
}
```
The cosa directory currently needs to be a subdirectory of the workspace
(see coreos#124).
Member
Draft in #125. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
dir()in the kola and kolaTestIso jobs the cd is happening on the controller (not in the COSA pod) so if the directory isn't under the env.WORKSPACE directory then we get a permission denied error.Let's go back to using a
cd ${cosaDir}for now to workaround this while we find better solutions. Thiscd ${cosaDir}will have no effect on multi-arch where we'll be operating in a remote session anyway.