Skip to content

dockerfile: update to Fedora 44#1744

Merged
prestist merged 1 commit into
coreos:mainfrom
marmijo:update-f44
May 12, 2026
Merged

dockerfile: update to Fedora 44#1744
prestist merged 1 commit into
coreos:mainfrom
marmijo:update-f44

Conversation

@marmijo

@marmijo marmijo commented May 8, 2026

Copy link
Copy Markdown
Member

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Fedora base image version from 43 to 44 in both the builder and runtime stages of the Dockerfile. The feedback suggests using a build argument (ARG) to define the Fedora version once, which improves maintainability and ensures consistency between stages to avoid potential runtime errors like GLIBC incompatibilities.

Comment thread Dockerfile
@@ -1,4 +1,4 @@
FROM quay.io/fedora/fedora:43 AS builder
FROM quay.io/fedora/fedora:44 AS builder

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure consistency between the builder and runtime stages, consider using a build argument (ARG) for the Fedora version. This avoids duplication and reduces the risk of version mismatches between stages, which can lead to runtime errors such as GLIBC incompatibilities.

ARG FEDORA_VERSION=44
FROM quay.io/fedora/fedora:${FEDORA_VERSION} AS builder

Comment thread Dockerfile
RUN cargo build --release

FROM quay.io/fedora/fedora:43
FROM quay.io/fedora/fedora:44

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use the FEDORA_VERSION argument defined at the top of the file to maintain consistency with the builder stage.

FROM quay.io/fedora/fedora:${FEDORA_VERSION}

@marmijo marmijo added the skip-notes This PR does not need release notes label May 8, 2026

@prestist prestist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestist prestist merged commit 5aa73e4 into coreos:main May 12, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants