dockerfile: update to Fedora 44#1744
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Fedora base image version from 43 to 44 in both the builder and runtime stages of the Dockerfile. The feedback suggests using a build argument (ARG) to define the Fedora version once, which improves maintainability and ensures consistency between stages to avoid potential runtime errors like GLIBC incompatibilities.
| @@ -1,4 +1,4 @@ | |||
| FROM quay.io/fedora/fedora:43 AS builder | |||
| FROM quay.io/fedora/fedora:44 AS builder | |||
There was a problem hiding this comment.
To improve maintainability and ensure consistency between the builder and runtime stages, consider using a build argument (ARG) for the Fedora version. This avoids duplication and reduces the risk of version mismatches between stages, which can lead to runtime errors such as GLIBC incompatibilities.
ARG FEDORA_VERSION=44
FROM quay.io/fedora/fedora:${FEDORA_VERSION} AS builder
| RUN cargo build --release | ||
|
|
||
| FROM quay.io/fedora/fedora:43 | ||
| FROM quay.io/fedora/fedora:44 |
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: coreos/fedora-coreos-tracker#2055