This repository was archived by the owner on Mar 28, 2020. It is now read-only.
pkg/controller: Fix CR with same name in different namespaces#2026
Merged
Conversation
This patch uses <namespace>/<cluster-name> as key to store the cluster in Controller struct to avoid over-writing same named CR's in different namespaces. Fixes coreos#1954
Collaborator
|
Can one of the admins verify this patch? |
2 similar comments
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
@etcd-bot ok to test |
Collaborator
|
@alaypatel07 thank you very much this looks great. Can you also update the CHANGELOG? |
Collaborator
Author
|
@hexfusion hope that works! |
Collaborator
|
lgtm |
Collaborator
|
@alaypatel07 thanks! |
|
thanks !! |
|
@hexfusion Any idea when the next etcd-operator release is gonna come out? We use a single etcd-operator with the cluster-wide option and we had several name clashes in the past in development environments, so this fix is highly appreciated. |
Collaborator
Collaborator
|
Hopefully next week on time-frame. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch uses
<namespace>/<cluster-name>as key to store the cluster in Controller struct to avoid over-writing same named CR's in different namespaces.Fixes #1954
Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow