Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

pkg/*: Fix long cluster names causing pods to hang#2027

Merged
hexfusion merged 1 commit into
coreos:masterfrom
alaypatel07:service-name
Jan 8, 2019
Merged

pkg/*: Fix long cluster names causing pods to hang#2027
hexfusion merged 1 commit into
coreos:masterfrom
alaypatel07:service-name

Conversation

@alaypatel07

Copy link
Copy Markdown
Collaborator

This patch restricts the name of the cluster to less than 52 characters. This simpler approach is preferred so it can be documented and explained to users easily. Operator log displays appropriate error for users.

Fixes #1994

Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow

@alaypatel07 alaypatel07 changed the title pkg/*: Fix long cluster names causing pods to hand pkg/*: Fix long cluster names causing pods to hang Dec 13, 2018
@etcd-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

2 similar comments
@etcd-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@etcd-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@hexfusion

Copy link
Copy Markdown
Collaborator

@alaypatel07 can you please rebase against master, thanks.

@alaypatel07

Copy link
Copy Markdown
Collaborator Author

@hexfusion sure, lemme know if I have to update the CHANGELOG too

@hexfusion

Copy link
Copy Markdown
Collaborator

@etcd-bot ok to test

@hexfusion

Copy link
Copy Markdown
Collaborator

@alaypatel07 yes, please add to CHANGELOG otherwise lgtm.

@hexfusion

Copy link
Copy Markdown
Collaborator

Small nit on commit message, s/hand/hang thanks!

This patch restricts the name of the cluster to less than 52 characters. This simpler approach is preferred so it can be documented. Operator log displays appropriate error for users.

Fixes coreos#1994
@hexfusion

Copy link
Copy Markdown
Collaborator

@alaypatel07 all we need is the CHANGELOG update and I can get this merged, thanks!

@hexfusion
hexfusion merged commit cb35c2d into coreos:master Jan 8, 2019
@christianhuening

Copy link
Copy Markdown

Is this in any release already? We're continuously running into this issue.

@hexfusion

Copy link
Copy Markdown
Collaborator

@christianhuening we are looking to cut a new release before the end of the month.

@christianhuening

Copy link
Copy Markdown

@hexfusion alright thanks!

@rohantmp

rohantmp commented Jan 28, 2019

Copy link
Copy Markdown

Can someone take a look at #2043? I made sure my etcdcluster name was short, but I still have a problem with this stage. I'm working on an operator that uses this operator.

@alaypatel07
alaypatel07 deleted the service-name branch January 29, 2019 18:42
@christianhuening

Copy link
Copy Markdown

@hexfusion Any updates on the release? We'd greatly appreciate it. Also because of #2026 .

@hexfusion

Copy link
Copy Markdown
Collaborator

Updated on #2026

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants