overlay/core: write ignition issues to /run

Since util-linux 2.41[1] agetty will source issues from multiples places
by default (` /etc`, `/run/` and  `/usr/lib`).

Systemd also worked around [2] this since v258 which has been in
fedora 43 for a while now, so let's always write our issues to
`/run`.

We add a check for RHEL to preserve the back-compatibility symlink.

[1] util-linux/util-linux@508fb0e
[2] systemd/systemd@864a5e9

Ref coreos/fedora-coreos-tracker#2108
See coreos/console-login-helper-messages#130

Author: jbtrystram

overlay.d/05core/usr/libexec/coreos-ignition-write-issues

@@ -18,7 +18,7 @@ if [ $(cat /proc/sys/kernel/random/boot_id) = "${ignitionBoot}" ]; then
     # checking for /run/ostree-live as the live system with persistent storage can run Ignition more than once
     if ! test -f /run/ostree-live && jq -e .previousReport.provisioningDate "${IGNITION_RESULT}" &>/dev/null; then
         prevdate=$(date --date "$(jq -r .previousReport.provisioningDate "${IGNITION_RESULT}")" +"%Y/%m/%d %H:%M:%S %Z")
-        cat << EOF > /etc/issue.d/30_coreos_ignition_run_more_than_once.issue
+        cat << EOF > /run/issue.d/30_coreos_ignition_run_more_than_once.issue
 ${WARN}
 ############################################################################
 WARNING: Ignition previously ran on ${prevdate}. Unexpected
@@ -49,7 +49,7 @@ EOF
     # TODO: find a way to query journal entries recorded before the
     # system switches to real root
     journalctl -t ignition -o cat -p warning | sed -r 's/, line [0-9]+ col [0-9]+//g' | sort -u | while read line; do
-        echo -e "${WARN}Ignition: $line${RESET}" >> /etc/issue.d/30_coreos_ignition_warnings.issue
+        echo -e "${WARN}Ignition: $line${RESET}" >> /run/issue.d/30_coreos_ignition_warnings.issue
     done
 else
     nreboots=$(($(journalctl --list-boots | wc -l) - 1))
@@ -66,6 +66,8 @@ else
         >> /run/issue.d/30_coreos_ignition_provisioning.issue
 fi
 
-# Our makeshift way of getting /run/issue.d semantics. See:
-# https://github.com/coreos/console-login-helper-messages/blob/e06fc88ae8fbcc3a422bc8c686f70c15aebb9d9a/usr/lib/console-login-helper-messages/issue.defs#L8-L17
-ln -sf /run/issue.d/30_coreos_ignition_provisioning.issue /etc/issue.d/
+# Until we have `util-linux-2.41` in RHCOS, we need to have the issues in /etc
+source /etc/os-release
+if [ "${ID}" == "rhel" ]; then
+    ln -sf /run/issue.d/30_coreos_ignition_*.issue /etc/issue.d/
+fi

overlay.d/15fcos/usr/libexec/coreos-check-ssh-keys

@@ -39,10 +39,10 @@ main() {
     fi
 
     if [ -n "$output" ]; then
-        echo "$output" > /etc/issue.d/30_ssh_authorized_keys.issue
+        echo "$output" > /run/issue.d/30_ssh_authorized_keys.issue
     else
         echo -e "${warn}No SSH authorized keys provided by Ignition or Afterburn${nc}" \
-            > /etc/issue.d/30_ssh_authorized_keys.issue
+            > /run/issue.d/30_ssh_authorized_keys.issue
     fi
 }
 

tests/kola/clhm/ignition-warnings/test.sh

@@ -15,7 +15,7 @@ WARN='\e\[0;33m' # yellow
 RESET='\e\[0m' # reset
 
 warning="${WARN}Ignition: warning at \\$.systemd.units.0.contents: unit \"echo.service\" is enabled, but has no install section so enable does nothing${RESET}"
-warningsfile="/etc/issue.d/30_coreos_ignition_warnings.issue"
+warningsfile="/run/issue.d/30_coreos_ignition_warnings.issue"
 
 # Check for the motd file
 if ! test -f ${warningsfile}; then