add CancelJob()#511
Merged
Merged
Conversation
Closed
kolyshkin
approved these changes
Mar 14, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM overall, let's wait till we fix CI.
kolyshkin
reviewed
Mar 14, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Collaborator
There was a problem hiding this comment.
Ah, can you please add dbus: prefix to commit subject?
Collaborator
|
Rebased to fix CI. |
kolyshkin
reviewed
Mar 16, 2026
kolyshkin
requested changes
Mar 16, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Collaborator
There was a problem hiding this comment.
@solarkennedy Needs a t.Context() fixup now (also, please add dbus: prefix to commit subject).
solarkennedy
force-pushed
the
add-cancel
branch
from
ef96028 to
23558ad
Compare
kolyshkin
approved these changes
Mar 16, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Collaborator
There was a problem hiding this comment.
this LGTM, can you please squash the commits @solarkennedy ?
We'd like to be able to cancel jobs using this API, so add a wrapper for it. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
solarkennedy
force-pushed
the
add-cancel
branch
from
8a802c0 to
749575d
Compare
Author
|
Rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to be able to cancel jobs using this API, so add a wrapper for it.
Rebased version of #426