filesystem: Virtiofs support#2227
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for virtiofs filesystems. Key changes include new error definitions, validation logic to ensure non-block devices do not use block-specific fields like UUIDs or labels, and updates to the execution stage to skip formatting and device-waiting for virtiofs tags. I have no feedback to provide.
angelcerveraroldan
force-pushed
the
virtiofs
branch
2 times, most recently
from
909d4f0 to
a3be2c9
Compare
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
Oh wow this is looking good, I did add some comments! feel free to push back
angelcerveraroldan
force-pushed
the
virtiofs
branch
2 times, most recently
from
d50cf33 to
52996f2
Compare
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
Overall this is looking good, the only nit I can see is that the commits should be squashed into 1 imo.
angelcerveraroldan
force-pushed
the
virtiofs
branch
from
52996f2 to
9bfb252
Compare
|
@angelcerveraroldan Sorry to keep picking the commit naming but I think we would be good to follow this pattern.
ex |
angelcerveraroldan
force-pushed
the
virtiofs
branch
from
9bfb252 to
4088778
Compare
|
Sorry for the commit messages! I had looked at the history, but was not exactly sure how to name it. I have updated it. |
Add support for virtiofs in the v3_7_experimental spec. Since virtiofs is not a block device, the device field is validated as a tag name rather than a path, and UUID, wipeFilesystem, label, and mkfs options are rejected at validation time.
angelcerveraroldan
force-pushed
the
virtiofs
branch
from
4088778 to
c07e4c7
Compare
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
@angelcerveraroldan no not a problem at all, just being particular! LGTM
2 participants
No description provided.