Skip to content

Commit e4b22c2

Browse files
authored
Merge pull request #421 from coreruleset/renovate/all-minor-patch
chore(deps): update all non-major dependencies in docker-bake.hcl
2 parents c582d3e + 77c8a75 commit e4b22c2

6 files changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/verifyimage.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ permissions:
1111
env:
1212
# sha256sum format: <hash><space><format (space for text)><file name>
1313
MODSECURITY_RECOMMENDED: "ccff8ba1f12428b34ff41960d8bf773dd9f62b9a7c77755247a027cb01896d4f modsecurity.conf-recommended"
14-
GO_FTW_VERSION: '1.3.0'
14+
GO_FTW_VERSION: '2.1.0'
1515

1616
jobs:
1717
prepare:
@@ -202,6 +202,10 @@ jobs:
202202
sed -i \
203203
's#image: owasp/modsecurity-crs:${{ contains(matrix.target, 'apache') && 'apache' || 'nginx' }}.*#image: ${{ matrix.target }}-verification#' \
204204
crs/tests/docker-compose.yml
205+
- name: Patch nginx overrides for nginx 1.30.0 (920100-4 now returns 405)
206+
run: |
207+
yq e -i '(.test_overrides[] | select(.rule_id == 920100 and .test_ids[0] == 4 and (.test_ids | length) == 1) | .output.status) = 405' \
208+
crs/tests/regression/nginx-overrides.yaml
205209
- name: Run CRS tests for ${{ matrix.target }}
206210
# Log flushing isn't reliable enough for go-ftw (https://github.com/coreruleset/go-ftw/issues/473)
207211
if: ${{!contains(matrix.target, 'nginx-alpine')}}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Examples:
6464

6565
## OS Variants
6666

67-
* nginx – *latest stable ModSecurity v3 on Nginx 1.28.2 official stable base image, and latest stable OWASP CRS 4.25.0*
67+
* nginx – *latest stable ModSecurity v3 on Nginx 1.30.0 official stable base image, and latest stable OWASP CRS 4.25.0*
6868
* [nginx](https://github.com/coreruleset/modsecurity-crs-docker/blob/master/nginx/Dockerfile)
6969
* [nginx-alpine](https://github.com/coreruleset/modsecurity-crs-docker/blob/master/nginx/Dockerfile-alpine)
7070
* Apache httpd – *last stable ModSecurity v2 on Apache 2.4.66 official stable base image, and latest stable OWASP CRS 4.25.0*

apache/Dockerfile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@ RUN set -eux; \
2727
libyajl-dev \
2828
lua${LUA_VERSION}-dev \
2929
make \
30-
pkgconf \
31-
wget
30+
pkgconf
3231

3332
RUN set -eux; \
34-
wget --quiet https://github.com/owasp-modsecurity/ModSecurity/archive/refs/tags/v${MODSEC2_VERSION}.tar.gz; \
35-
tar -zxvf v${MODSEC2_VERSION}.tar.gz; \
33+
git clone https://github.com/owasp-modsecurity/ModSecurity --branch "v${MODSEC2_VERSION}" --depth 1 --recursive ModSecurity-${MODSEC2_VERSION}; \
3634
cd ModSecurity-${MODSEC2_VERSION}; \
3735
./autogen.sh; \
3836
./configure ${MODSEC2_FLAGS}; \

apache/Dockerfile-alpine

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ RUN set -eux; \
2323
geoip-dev \
2424
gcc \
2525
g++ \
26+
git \
2627
gnupg \
2728
libc-dev \
2829
libfuzzy2-dev \
@@ -41,8 +42,7 @@ RUN set -eux; \
4142
zlib-dev
4243

4344
RUN set -eux; \
44-
wget --quiet https://github.com/owasp-modsecurity/ModSecurity/archive/refs/tags/v${MODSEC2_VERSION}.tar.gz; \
45-
tar -zxvf v${MODSEC2_VERSION}.tar.gz; \
45+
git clone https://github.com/owasp-modsecurity/ModSecurity --branch "v${MODSEC2_VERSION}" --depth 1 --recursive ModSecurity-${MODSEC2_VERSION}; \
4646
cd ModSecurity-${MODSEC2_VERSION}; \
4747
./autogen.sh; \
4848
./configure ${MODSEC2_FLAGS}; \

docker-bake.hcl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# docker-bake.hcl
22
variable "modsec3-version" {
33
# renovate: depName=ModSecurity3 packageName=owasp-modsecurity/ModSecurity datasource=github-releases
4-
default = "3.0.14"
4+
default = "3.0.15"
55
}
66

77
variable "modsec3-flags" {
@@ -10,7 +10,7 @@ variable "modsec3-flags" {
1010

1111
variable "modsec2-version" {
1212
# renovate: depName=ModSecurity2 packageName=owasp-modsecurity/ModSecurity datasource=github-releases
13-
default = "2.9.12"
13+
default = "2.9.13"
1414
}
1515

1616
variable "modsec2-flags" {
@@ -40,7 +40,7 @@ variable "crs-versions" {
4040

4141
variable "nginx-version" {
4242
# renovate: depName=nginxinc/nginx-unprivileged datasource=docker
43-
default = "1.28.2"
43+
default = "1.30.0"
4444
}
4545

4646
variable "httpd-version" {

nginx/Dockerfile-alpine

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ RUN set -eux; \
3737
make \
3838
openssl \
3939
openssl-dev \
40-
patch \
4140
pkgconfig \
4241
pcre2-dev \
4342
yajl-dev \
@@ -51,7 +50,6 @@ RUN set -eux; \
5150
ARCH=$(gcc -print-multiarch); \
5251
sed -ie "s/i386-linux-gnu/${ARCH}/g" build/ssdeep.m4; \
5352
sed -ie "s/i386-linux-gnu/${ARCH}/g" build/pcre2.m4; \
54-
curl -sSL https://patch-diff.githubusercontent.com/raw/owasp-modsecurity/ModSecurity/pull/3473.patch | patch -p1; \
5553
./build.sh; \
5654
./configure ${MODSEC3_FLAGS}; \
5755
make -j$(nproc) install; \

0 commit comments

Comments
 (0)