Merge pull request #12 from corka149/11-performance-improvements-of-diff

11 performance improvements of diff

Author: corka149

CHANGELOG

@@ -1,3 +1,6 @@
+# 0.13.1
+- Make Jsonpatch faster by (un)escaping conditional
+
 # 0.13.0
 - Allow usage of atoms for keys via `keys` option
 

README.md

@@ -32,7 +32,7 @@ The package can be installed by adding `jsonpatch` to your list of dependencies
 ```elixir
 def deps do
   [
-    {:jsonpatch, "~> 0.12.1"}
+    {:jsonpatch, "~> 0.13.1"}
   ]
 end
 ```

lib/jsonpatch.ex

@@ -216,14 +216,21 @@ defmodule Jsonpatch do
     Map.get(source, key)
   end
 
-  # Escape `/` to `~1 and `~` to `~`.
+  # Escape `/` to `~1 and `~` to `~0`.
   defp escape(subpath) when is_bitstring(subpath) do
     subpath
-    |> String.replace("~", "~0")
-    |> String.replace("/", "~1")
+    |> do_escape("~", "~0")
+    |> do_escape("/", "~1")
   end
 
   defp escape(subpath) do
     subpath
   end
+
+  defp do_escape(subpath, pattern, replacement) do
+    case String.contains?(subpath, pattern) do
+      true -> String.replace(subpath, pattern, replacement)
+      false -> subpath
+    end
+  end
 end

lib/jsonpatch/path_util.ex

@@ -75,8 +75,8 @@ defmodule Jsonpatch.PathUtil do
   """
   def unescape(fragment) when is_bitstring(fragment) do
     fragment
-    |> String.replace("~1", "/")
-    |> String.replace("~0", "~")
+    |> do_unescape("~1", "/")
+    |> do_unescape("~0", "~")
   end
 
   def unescape(fragment) do
@@ -194,4 +194,15 @@ defmodule Jsonpatch.PathUtil do
   defp is_number?(_term) do
     false
   end
+
+  defp do_unescape(fragment, pattern, replacement) when is_binary(fragment) do
+    case String.contains?(fragment, pattern) do
+      true -> String.replace(fragment, pattern, replacement)
+      false -> fragment
+    end
+  end
+
+  defp do_unescape(fragment, _pattern, _replacement) do
+    fragment
+  end
 end

mix.exs

@@ -6,7 +6,7 @@ defmodule Jsonpatch.MixProject do
       app: :jsonpatch,
       name: "Jsonpatch",
       description: "Implementation of RFC 6902 in pure Elixir",
-      version: "0.13.0",
+      version: "0.13.1",
       elixir: "~> 1.10",
       start_permanent: Mix.env() == :prod,
       deps: deps(),