Skip to content

New Home Page Overlays#306

Open
gselina wants to merge 7 commits into
masterfrom
new-home-page-overlays
Open

New Home Page Overlays#306
gselina wants to merge 7 commits into
masterfrom
new-home-page-overlays

Conversation

@gselina
Copy link
Copy Markdown
Contributor

@gselina gselina commented Apr 12, 2026

Summary

This pull request is the first step towards implementing the new home page by building the frontend overlay UI for the new Home page. Changes are UI-only: created the components and layout, but real functionality has not been implemented (API calls, no filtering logic, navigation behavior)

  • implemented search bar with filter button
  • created static filter chips as reusable chip components (for Food, Speakers, Concerts, etc)
  • created reusable event pins for each state
  • home tab shows map + overlays

Remaining TODOs:

  • update selected pin icon (currently all burger)

Test Plan

home.page.overlays.test.mp4

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gselina
❌ Selina Ge


Selina Ge seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jjasonguo
Copy link
Copy Markdown
Contributor

Looks very good Selina. Very clean changes when testing on my emulator. We should consider what the journey tap should lead to next

3TTemi

This comment was marked as low quality.

@3TTemi
Copy link
Copy Markdown
Collaborator

3TTemi commented Apr 15, 2026

Great work! I tested this in the simulator, and the UI looks really good.

To align with our coding standards and make this easier to review/maintain, you should make these improvements though:

  • Refactor home_page.dart: the file is really large. You can break it up into smaller, modular Dart files like: Category Chips, Map Pin Utilities, and Search Bar
  • Documentation: Add comments or headers to define the different sections of the code. This will help guide future contributors through the logic more easily

Comment thread game/lib/navigation_page/bottom_navbar.dart Outdated
Comment thread game/lib/navigation_page/home_map_page.dart Outdated
@dti-github-bot
Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 1366. This diff might be too big! Developer leads are invited to review the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants