Jhg294/events bottom sheet#307
Conversation
|
[diff-counting] Significant lines: 2508. This diff might be too big! Developer leads are invited to review the code. |
|
Good job Jason! I would elaborate more on the TODO, like including the "Set Reminders feature", the dotted line showing the path to the event, and adding in more icons for the events besides the restaurant one (once they are made), and adding in pins for the events where they are located (maybe just a placeholder one on the screen until the backend is connected). |
|
UI looking good! But first thing I noticed when trying out in simulator is that the touch area for the bottom sheet is buggy. Seem to only be able to move it from the list view not the header or drag bar |
|
|
||
| List<EventDto> _filteredEvents( | ||
| UserModel userModel, | ||
| EventModel eventModel, |
There was a problem hiding this comment.
Lowkey not your fault since it wasn't developed at the time you made this branch but were supposed to be using campuseventModel and using the campuseventDTO as well not eventModel. This makes it so its shows actual events and not challenges.
If you merge master you will get these models and DTOs
(need to change eventModel name so this is more clear, will do)
|
thanks for feedback, addressed draggable area and repeating api call in the build. will continue with the correct campuseventmodel when merging changes with Selina's! |
…294/events-bottom-sheet
|
Selina Ge seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Summary
This pull request is the first step towards implementing the new event based ui of cornellgo. It creates the bottom sheet page that will display event. Currently, the GO button has no functionality. Retrieved events are sorted by end time first, then location. subject to change in the future. They have a hosted by with default black circle for now too.
Update 4/30:
This PR now has the events home page incorporated, with working go functionality and gcal integration for future events. Things to consider are when we want the event to say "GO" vs "add to gcal", and also whether the dotted line for navigation should be straight or like an actual path using google maps api.
Remaining TODOs:
Test Plan
Notes
Blockers
Breaking Changes