remaining backend changes

Author: anchen9

apps/dashboard/convex/bookmarks.ts

@@ -53,6 +53,10 @@ async function findBookmark(
     .unique();
 }
 
+function isPublished(event: Doc<"events">): boolean {
+  return event.visibility !== "draft" && event.visibility !== "hidden";
+}
+
 export const bookmark = mutation({
   args: { eventId: v.id("events") },
   handler: async (ctx, args) => {
@@ -64,6 +68,14 @@ export const bookmark = mutation({
       });
     }
 
+    const event = await ctx.db.get(args.eventId);
+    if (event === null || !isPublished(event)) {
+      throw new ConvexError({
+        code: "EVENT_NOT_FOUND",
+        message: "This event is not available to bookmark.",
+      });
+    }
+
     const existing = await findBookmark(ctx, userId, args.eventId);
     if (existing !== null) {
       // Idempotent: already bookmarked.
@@ -132,6 +144,7 @@ export const myBookmarks = query({
     for (const row of result.page) {
       const event = await ctx.db.get(row.eventId);
       if (event === null) continue;
+      if (!isPublished(event)) continue;
       const orgs = await loadOrgsForEvent(ctx, event._id);
       hydrated.push({ bookmark: row, event, orgs });
     }

apps/dashboard/convex/events.ts

@@ -28,8 +28,7 @@ const FEED_MIN_ITEMS = 20;
 // Bounded pool size when pulling recommended events to dedupe + backfill from.
 const RECOMMENDED_POOL_SIZE = 50;
 // Bounded scan sizes for the interest-personalised recommendation pass. Kept
-// small so the feed query stays cheap; the full ranking model lives on a
-// separate branch and will replace this stub.
+// small so the feed query stays cheap while still providing relevant backfill.
 const RECOMMENDED_ORG_SCAN = 100;
 const RECOMMENDED_EVENTS_PER_ORG = 10;
 
@@ -303,7 +302,7 @@ export const getById = query({
   args: { eventId: v.id("events") },
   handler: async (ctx, args): Promise<HydratedEvent | null> => {
     const event = await ctx.db.get(args.eventId);
-    if (event === null) {
+    if (event === null || !isPublished(event)) {
       return null;
     }
     const userId = await getAuthUserId(ctx);
@@ -407,8 +406,11 @@ export const getEmailContent = query({
     ctx,
     args,
   ): Promise<{ subject: string; paragraphs: string[] } | null> => {
+    const userId = await getAuthUserId(ctx);
+    if (userId === null) return null;
+
     const event = await ctx.db.get(args.eventId);
-    if (event === null) return null;
+    if (event === null || !isPublished(event)) return null;
 
     if (event.sourceMessageId !== undefined) {
       const msg = await ctx.db.get(event.sourceMessageId);

apps/dashboard/convex/seed.ts

@@ -85,6 +85,11 @@ export const seedAll = internalMutation({
         isSeed: true,
       });
       summary.listservEmails += 1;
+    } else {
+      await ctx.db.patch(listservId, {
+        sentAt: now,
+        rawText: "Seed listserv parent row.",
+      });
     }
 
     // 2. Orgs (skip if a row with this slug already exists).

apps/extension/src/data/useEvents.ts

@@ -30,7 +30,7 @@ export interface OrgSection {
  * All EventItem.id values originate from event._id in the mapper, so the
  * narrowing is sound even though the brand cannot be checked at runtime.
  */
-function isEventId(id: string): id is Id<"events"> {
+export function isEventId(id: string): id is Id<"events"> {
   return id.length > 0;
 }
 
@@ -139,7 +139,7 @@ export function useBookmarks(): { ids: Set<string>; events: EventItem[] } {
   if (result === undefined) return { ids: new Set(), events: [] };
 
   const events = result.page.map(mapBookmark);
-  const ids = new Set(result.page.map((b) => b.event._id as string));
+  const ids = new Set<string>(result.page.map((b) => b.event._id));
   return { ids, events };
 }