Skip to content

Annie/UI fixes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anchen9 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Annie/UI fixes #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
155651c
ui fixes (draggable, icon size)
anchen9 May 3, 2026
d194518
more ui fixes
anchen9 May 3, 2026
cee0ffd
toolbar logo change
anchen9 May 6, 2026
bbd7792
Address PR #11 review comments on FloatingPanel
anchen9 May 20, 2026
ade4ead
Adjust the dismiss button positioning logic
anchen9 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/extension/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
"action": {
"default_title": "Cornell Loop",
"default_icon": {
"16": "popup_icon.png",
"32": "popup_icon.png",
"48": "popup_icon.png",
"128": "popup_icon.png"
"16": "loop_logo.png",
"32": "loop_logo.png",
"48": "loop_logo.png",
"128": "loop_logo.png"
}
},
"icons": {
"16": "popup_icon.png",
"32": "popup_icon.png",
"48": "popup_icon.png",
"128": "popup_icon.png"
"16": "loop_logo.png",
"32": "loop_logo.png",
"48": "loop_logo.png",
"128": "loop_logo.png"
},
"background": {
"service_worker": "src/background.ts",
Expand Down
27 changes: 18 additions & 9 deletions apps/extension/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,12 @@ export interface AppProps {
onPreviewSlot?: (event: EventItem | null) => void;
}

const DASHBOARD_URL =
(import.meta.env.VITE_DASHBOARD_URL as string | undefined) ??
"https://cornellloop.com";
const DASHBOARD_URL = (() => {
const value = import.meta.env.VITE_DASHBOARD_URL;
return typeof value === "string" && value.length > 0
? value
: "https://cornellloop.com";
})();

export default function App({
onClose,
Expand Down Expand Up @@ -59,9 +62,9 @@ export default function App({
const isSearchMode = view === "search" || view === "email";

const handleTabChange = (tab: string) => {
const t = tab as "feed" | "bookmarks";
setActiveTab(t);
setView(t);
if (tab !== "feed" && tab !== "bookmarks") return;
setActiveTab(tab);
setView(tab);
setEmailEvent(null);
};

Expand Down Expand Up @@ -92,7 +95,7 @@ export default function App({
style={{ boxShadow: "0px 4px 16px rgba(0, 0, 0, 0.18)" }}
>
{/* ── Sticky header ── */}
<div className="shrink-0 px-6 pt-7">
<div className="shrink-0 px-6 pt-7" data-loop-panel-drag>
<SearchHeader
variant={isSearchMode ? "search" : "main"}
activeTab={activeTab}
Expand All @@ -109,7 +112,10 @@ export default function App({
{/* ── Main content: search uses pinned footer CTA; other views scroll with CTA inline ── */}
{view === "search" ? (
<div className="flex min-h-0 flex-1 flex-col">
<div className="min-h-0 flex-1 overflow-y-auto px-6 py-[21px]">
<div
className="min-h-0 flex-1 overflow-y-auto px-6 py-[21px]"
data-loop-scroll
>
<SearchView
query={searchQuery}
onSearchSelect={handleSearchSelect}
Expand Down Expand Up @@ -137,7 +143,10 @@ export default function App({
</div>
</div>
) : (
<div className="min-h-0 flex-1 overflow-y-auto px-6 py-[21px]">
<div
className="min-h-0 flex-1 overflow-y-auto px-6 py-[21px]"
data-loop-scroll
>
{view === "feed" && (
<FeedView
bookmarkedIds={bookmarkedIds}
Expand Down
12 changes: 10 additions & 2 deletions apps/extension/src/background.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,10 @@
// No side panel logic needed — UI is injected via content script.
export {};
// When the user clicks the toolbar icon, tell the active tab's content script
// to re-show the floating panel (in case it was previously dismissed).
chrome.action.onClicked.addListener((tab) => {
if (tab.id === undefined) return;
void chrome.tabs
.sendMessage(tab.id, { type: "LOOP_SHOW_PANEL" })
.catch(() => {
// Content script not injected on this page — silently ignore.
});
});
Loading
Loading