Nikhill/dashboard cont#13
Open
NikhillA wants to merge 29 commits into
Open
Conversation
- accomodate shared design system components - have dashboard + extension split
…l-dti/cornell-loop into annie/setup-design-system
Convex Schema
Remove broken feed Toggle, move SearchBar into feed header, swap hardcoded Landing hex for secondary-500 token, add Manrope to font link. Wire RoutedHome with client-side sample posts / side panels (Convex schema has no post table yet). New playwright helper for /home screenshots. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Brings in DS component polish (Avatar, Button, Cards, DateBadge, Logo, SearchBar/Panel, SideBar, Tags, Toggle), new components (Bookmark, Dropdown, OrgHoverCard), token updates, shared fallbackColors util, prettier config, and README/CI tweaks. Conflict resolutions: - Kept HEAD monorepo layout: all DS code lives under shared/ui, apps/dashboard imports via @app/ui barrel. - Moved annie's root src/components/* + src/utils/* under shared/ui/src/. - Dropped stray pre-monorepo root files (src/App.tsx, src/main.tsx, vite.config.ts) — replaced long ago by apps/dashboard equivalents. - Rewrote DesignSystem.tsx imports to use @app/ui and @app/ui/assets/* subpath; added ./assets/* to shared/ui package exports. - Extended shared/ui/src/index.ts to re-export Bookmark, Dropdown, OrgHoverCard. - Added lucide-react as peer dep (shared/ui) and dep (apps/dashboard) — multiple DS components rely on it. - Root package.json keeps workspace-dispatch scripts; added prettier format / format:check scripts + dev deps. - Kept Manrope font link addition from previous commit. - Dropped annie's committed .env (contained a rotated Gemini API key — pre-existing leak on source branch, addressed separately). Added .env / .env.local to .gitignore. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
anchen9
reviewed
May 6, 2026
anchen9
left a comment
anchen9
left a comment
Contributor
There was a problem hiding this comment.
Great work overall Nikhill on implementing the dashboard frontend! (Also great work to Megan for the initial wiring)! The dashboard's looking great and really appreciate your work this semester!
|
|
||
| const ALLOWED_EMAIL_DOMAIN = "@cornell.edu"; | ||
|
|
||
| export const { auth, signIn, signOut, store, isAuthenticated } = convexAuth({ |
Contributor
There was a problem hiding this comment.
Great job working with convex auth & checking for non-cornell emails!
| ); | ||
| } | ||
|
|
||
| export const currentUser = query({ |
Contributor
There was a problem hiding this comment.
I wonder if this non-cornell user logic could be consolidated with the code in convex/auth.ts?
Contributor
There was a problem hiding this comment.
Very useful having some dev only tools and shortcuts, but I think this file is inhibiting some local testing for auth on the fakeSignIn function! We can probably either implement an override or remove the shortcuts before implementing auth fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary This PR adds the UI for various pages on the Loop dashboard (home, subscriptions, bookmarks, profile, org page). This pages were created using already made cards and components shared from previous development.
This pull request is the first step towards implementing feature dashboard
Remaining TODOs:
Check BE connectivity
Depends on #{number of PR}
Test Plan
Notes
Breaking Changes