Coffee Chat suggestions/category refactor#1149
Open
ladriennel wants to merge 6 commits into
Open
Conversation
Member
|
[diff-counting] Significant lines: 518. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, coffee chat suggestions are stored quite inefficiently where every member has a reference to all other members satisfying each category. Every semester, you had to manually update a
COFFEE_CHAT_BINGO_BOARDconstant in code, run the script, and open a PR. With this refactor, the collection is now modeled after the categories: there will be 16 Firestore documents for each bingo board category with an index denoting its position on the board and storing a list of all associated members.Notion
Test Plan
Notes