Skip to content

feat: volume cropping #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wayfarer3130 merged 134 commits into from
Jul 28, 2025
Merged

feat: volume cropping #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
fab32ed
feat(volumeCropping): Add 3D Volume Cropping tool example
mbellehumeur Apr 16, 2025
386e24d
feat(volumeCropping): Enhance 3D Volume Cropping with Trackball rotat…
mbellehumeur Jun 11, 2025
b47fa33
feat(volumeCropping): Implement original clipping planes management i…
mbellehumeur Jun 12, 2025
54f585f
feat(volumeCropping): Enhance VolumeCroppingTool with mouse and touch…
mbellehumeur Jun 12, 2025
4e3d725
refactor(volumeCropping): Clean up TrackballRotateTool integration an…
mbellehumeur Jun 12, 2025
a1a4504
Merge branch 'cornerstonejs:main' into feat-volume-cropping
mbellehumeur Jun 12, 2025
b946aed
Add VolumeCroppingTool to tools index
mbellehumeur Jun 13, 2025
7b64865
feat: Restrict TrackballRotateTool to VOLUME_3D viewports and refacto…
mbellehumeur Jun 16, 2025
9338ca1
feat(volumeCropping): Add axis parameter to addSphere method and upda…
mbellehumeur Jun 16, 2025
b6fcbbd
Merge branch 'feat-volume-cropping' of https://github.com/mbellehumeu…
mbellehumeur Jun 16, 2025
b5f4021
feat(volumeCropping): Enhance sphere management with dragging functio…
mbellehumeur Jun 17, 2025
4b719f7
feat(volumeCropping): Refactor VolumeCroppingTool by removing unused …
mbellehumeur Jun 17, 2025
4f88edb
refactor(volumeCropping): Remove unused functions and variables to st…
mbellehumeur Jun 17, 2025
c503f57
feat(volumeCropping): Add sphere color configuration and improve anno…
mbellehumeur Jun 18, 2025
057d367
working example before split in 2 tools.
mbellehumeur Jun 19, 2025
5c9dc6f
Add VolumeCroppingControlTool to tools index export
mbellehumeur Jun 20, 2025
e796bfb
feat(volumeCropping): Add StackScrollTool and enhance viewport handli…
mbellehumeur Jun 20, 2025
b512865
feat(volumeCropping): Add viewport indicators and sphere moved event …
mbellehumeur Jun 20, 2025
f247511
feat(volumeCropping): Enhance VolumeCroppingTool with additional mous…
mbellehumeur Jun 21, 2025
1ea4504
fix(volumeCropping): Update event names for VolumeCroppingControlTool…
mbellehumeur Jun 21, 2025
6d8f279
feat(volumeCropping): Update VolumeCroppingTool and VolumeCroppingCon…
mbellehumeur Jun 21, 2025
a5bc9f2
other sphere movement
mbellehumeur Jun 22, 2025
c1a69b1
feat(volumeCropping): Add sphere color customization and viewport ori…
mbellehumeur Jun 23, 2025
946df82
refactor(volumeCropping): Clean up commented code and add debug loggi…
mbellehumeur Jun 23, 2025
14d8844
fix(volumeViewport3D): Initialize _originalClippingPlanes in constructor
mbellehumeur Jun 23, 2025
fe2d823
feat(volumeCropping): Integrate CrosshairsTool and enhance sphere han…
mbellehumeur Jun 24, 2025
549f047
refactor(volumeCropping): Replace hardcoded crop factor with configur…
mbellehumeur Jun 24, 2025
ceed202
feat(volumeCropping): Add toolCenterMin and toolCenterMax properties …
mbellehumeur Jun 24, 2025
f166e2b
refactor(volumeCropping): Adjust viewport styles and update reference…
mbellehumeur Jun 25, 2025
1b8045f
feat(volumeCropping): Enhance VolumeCroppingControlTool with toolCent…
mbellehumeur Jun 25, 2025
996b808
refactor(volumeCropping): Adjust viewport width and clean up unused c…
mbellehumeur Jun 25, 2025
519de23
refactor(volumeCropping): Clean up debug statements in VolumeCropping…
mbellehumeur Jun 26, 2025
4d20507
refactor(volumeCropping): Optimize clipping plane management in Volum…
mbellehumeur Jun 26, 2025
8d22b58
refactor(volumeCropping): Update instructions and clean up commented …
mbellehumeur Jun 28, 2025
8b82cec
refactor(volumeCropping): Improve type definitions and clean up unuse…
mbellehumeur Jun 29, 2025
668388c
refactor(volumeCropping): Clean up commented code and improve readabi…
mbellehumeur Jul 3, 2025
984d4e7
refactor(volumeCropping): Enhance corner sphere movement logic and up…
mbellehumeur Jul 3, 2025
a4162d0
refactor(volumeCropping): Enhance corner sphere movement logic and up…
mbellehumeur Jul 6, 2025
31b0525
refactor(volumeCropping): Simplify edge cylinder creation and update …
mbellehumeur Jul 6, 2025
a9a2c93
refactor(volumeCropping): Remove commented-out code and enhance face …
mbellehumeur Jul 6, 2025
36b4cbb
refactor(volumeCropping): Add line intersection calculation for impro…
mbellehumeur Jul 6, 2025
4cd6a03
refactor(volumeCropping): Adjust line width and cylinder radius for i…
mbellehumeur Jul 7, 2025
a4f734d
Added Toggle 3D handles visible
mbellehumeur Jul 7, 2025
76be852
refactor(volumeCropping): Update documentation and clean up comments …
mbellehumeur Jul 9, 2025
cd4a3ad
refactor(tools): Enhance type definitions and improve clarity in PanT…
mbellehumeur Jul 9, 2025
abdb5a6
refactor(volumeCropping): Simplify addNewAnnotation and cancel method…
mbellehumeur Jul 9, 2025
804bb2b
refactor(tools): Integrate VolumeCroppingTool's originalClippingPlane…
mbellehumeur Jul 9, 2025
b439cfd
refactor(volumeCropping): Enhance type definitions and add getVtkDisp…
mbellehumeur Jul 9, 2025
1bf889b
refactor(volumeCropping): Clean up imports and adjust getVtkDisplayCo…
mbellehumeur Jul 9, 2025
99f2c76
refactor(volumeCropping): Remove commented-out code and improve clari…
mbellehumeur Jul 9, 2025
0a5058f
refactor(volumeViewport3D): Remove unnecessary blank lines in VolumeV…
mbellehumeur Jul 9, 2025
622e4e9
refactor(volumeCropping): Make initial crop factor configurable in Vo…
mbellehumeur Jul 10, 2025
b809a48
fix(volumeCropping): Add checks for volume actors and image data in V…
mbellehumeur Jul 10, 2025
d3f2efc
refactor(volumeCropping): Simplify actor checks and clipping plane ad…
mbellehumeur Jul 10, 2025
807b90c
fix(volumeCropping): Add checks for volume actors and use enums for a…
mbellehumeur Jul 10, 2025
eb85f25
Replace clipping plane handling in pan,zoom and rotate by events.
mbellehumeur Jul 10, 2025
4f1597f
refactor(volumeCropping): Simplify origin and normal extraction in Vo…
mbellehumeur Jul 10, 2025
970b249
refactor(tools): Remove unused vtkPlane imports from PanTool, Trackba…
mbellehumeur Jul 10, 2025
a8f5eb9
Use CAMERA_MODIFIED event name.
mbellehumeur Jul 11, 2025
4d75442
refactor(TrackballRotateTool): remove viewport type check for VOLUME_…
mbellehumeur Jul 11, 2025
b279072
Remove unused function _areViewportIdArraysEqual and other unused fun…
mbellehumeur Jul 11, 2025
b2cb1ea
use vec3 transform
mbellehumeur Jul 11, 2025
825e077
refactor(VolumeCroppingTool): replace custom normal transformation wi…
mbellehumeur Jul 11, 2025
9638ee1
Use robust transform
mbellehumeur Jul 11, 2025
6937964
Normalize direction vectors
mbellehumeur Jul 11, 2025
db2b380
Normalize the transform in updateClippingPlanes
mbellehumeur Jul 11, 2025
26ba56c
fix(addCylinderBetweenPoints): prevent cylinder creation for identica…
mbellehumeur Jul 12, 2025
6cd257a
refactor(VolumeCroppingTool): simplify corner sphere position updates…
mbellehumeur Jul 12, 2025
8abce5f
refactor(VolumeCroppingTool): enhance mouse movement handling for sph…
mbellehumeur Jul 12, 2025
65943c3
Remove 3D picker
mbellehumeur Jul 13, 2025
4a06d67
refactor(VolumeCroppingTool): update handle visibility logic and impl…
mbellehumeur Jul 13, 2025
ea019ef
refactor(VolumeCroppingTool): add face drag offset handling for impro…
mbellehumeur Jul 14, 2025
eb908d1
Add dashed extended control line option
mbellehumeur Jul 14, 2025
c720ec5
use CAMERA_MODIFIED event
mbellehumeur Jul 14, 2025
ef15cca
fix(PanTool, ZoomTool): clean up imports and ensure viewport renders …
mbellehumeur Jul 14, 2025
f492297
refactor(VolumeCroppingTool): update handle visibility logic to synch…
mbellehumeur Jul 14, 2025
0dbbd8e
refactor(VolumeCroppingTool): add type annotations for improved type …
mbellehumeur Jul 14, 2025
d1aa6bc
refactor(VolumeCroppingTool): remove viewport parameter from _updateC…
mbellehumeur Jul 14, 2025
e2ccc5a
Stack scroll should not change clipping planes
mbellehumeur Jul 14, 2025
140b810
refactor(VolumeCroppingControlTool): remove commented-out _onSphereMo…
mbellehumeur Jul 15, 2025
fb24908
refactor(VolumeCroppingTool): remove viewport parameter from _updateC…
mbellehumeur Jul 15, 2025
32663a8
refactor(VolumeCroppingTool): update initial crop factor, enable corn…
mbellehumeur Jul 15, 2025
8c3365f
Add rotate to tool
mbellehumeur Jul 16, 2025
ad31963
refactor(VolumeCroppingTool): remove debug logs and unused mouse even…
mbellehumeur Jul 16, 2025
5e1febc
feat(VolumeCroppingTool): add clipping planes visibility toggle and r…
mbellehumeur Jul 16, 2025
82d2cb1
feat(VolumeCroppingTool): implement edge lines for corner spheres and…
mbellehumeur Jul 16, 2025
ed4af8f
refactor(VolumeCroppingTool): adjust line width and initial crop fact…
mbellehumeur Jul 17, 2025
95ade48
feat(VolumeCroppingControlTool): add viewport-based tool center updat…
mbellehumeur Jul 17, 2025
21d7b49
refactor(VolumeCroppingTool): update mouse bindings and adjust sphere…
mbellehumeur Jul 17, 2025
bb896c6
fix(VolumeCroppingTool): add check for default actor in viewport befo…
mbellehumeur Jul 17, 2025
ac27de7
refactor(VolumeCroppingControlTool): remove redundant viewport initia…
mbellehumeur Jul 18, 2025
7baba83
feat(VolumeCroppingControlTool): synthesize virtual annotations for m…
mbellehumeur Jul 18, 2025
38d12f8
refactor(VolumeCroppingControlTool): streamline virtual annotation ha…
mbellehumeur Jul 18, 2025
c7f97c3
feat(VolumeCroppingControlTool): synthesize virtual annotations for m…
mbellehumeur Jul 19, 2025
2271cc5
fix(VolumeCroppingControlTool): cast annotation to any for virtualNor…
mbellehumeur Jul 19, 2025
4529704
fix(VolumeCroppingControlTool): specify type for virtualAnnotation an…
mbellehumeur Jul 19, 2025
2ccb251
refactor(VolumeCroppingTool): optimize clipping plane updates and imp…
mbellehumeur Jul 19, 2025
f904631
feat(VolumeCroppingControlTool): add orientation mapping from camera …
mbellehumeur Jul 19, 2025
9f88b07
fix(VolumeCroppingControlTool): correct viewport orientation handling…
mbellehumeur Jul 19, 2025
d91b028
fix(VolumeCroppingControlTool): improve virtual annotation synthesis …
mbellehumeur Jul 19, 2025
6bb7bed
fix(VolumeCroppingControlTool): update type annotations for reference…
mbellehumeur Jul 19, 2025
99f56d6
refactor(VolumeCroppingControlTool): remove debug logging for viewpor…
mbellehumeur Jul 19, 2025
37f27c2
refactor(VolumeCroppingControlTool): simplify orientation determinati…
mbellehumeur Jul 19, 2025
e1398fd
feat(VolumeCroppingControlTool): add configurable dropdown for number…
mbellehumeur Jul 19, 2025
cfaf1cd
feat(VolumeCroppingControlTool): add configurable line colors for ref…
mbellehumeur Jul 19, 2025
2147942
feat(VolumeCroppingTool): add configurable line widths for reference …
mbellehumeur Jul 20, 2025
536b8b6
refactor(VolumeCroppingTool): remove debug logging for tool activatio…
mbellehumeur Jul 20, 2025
7122963
feat(VolumeCroppingControlTool): add annotation existence check befor…
mbellehumeur Jul 20, 2025
2daa7d7
fix(VolumeCroppingControlTool): correct start and end points for dash…
mbellehumeur Jul 21, 2025
21e9d90
fix(VolumeCroppingControlTool): disable extending reference lines by …
mbellehumeur Jul 21, 2025
d081048
fix(VolumeCroppingControlTool): enable extending reference lines by d…
mbellehumeur Jul 21, 2025
7487051
fix(VolumeCroppingControlTool): improve dashed line rendering by sort…
mbellehumeur Jul 21, 2025
2877fcc
fix(VolumeCroppingControlTool): enhance sphere movement handling and …
mbellehumeur Jul 21, 2025
44ced22
Implement review comments regarding naming and position
mbellehumeur Jul 21, 2025
fed4eba
refactor(VolumeCroppingTool): simplify viewport retrieval by introduc…
mbellehumeur Jul 21, 2025
f40e3e5
refactor(VolumeCroppingTool): clean up imports and reorganize handle …
mbellehumeur Jul 21, 2025
e69b7cb
fix(VolumeCroppingTool): add debug log for cleanup process after mouseup
mbellehumeur Jul 22, 2025
fdb097b
Fix rendering problem in OHIF when moving the first sphere quickly.
mbellehumeur Jul 22, 2025
c91fa62
feat(VolumeCroppingTool): sync tool centers with clipping planes
mbellehumeur Jul 22, 2025
7f35faa
refactor(VolumeCroppingTool): enhance documentation and restructure o…
mbellehumeur Jul 22, 2025
072c6d7
feat(VolumeCroppingTool): implement adaptive sphere radius calculatio…
mbellehumeur Jul 22, 2025
56c11a0
feat(VolumeCroppingTool): implement adaptive sphere radius calculatio…
mbellehumeur Jul 22, 2025
bb01e74
feat(VolumeCroppingTool): initialize state variables for new volume p…
mbellehumeur Jul 23, 2025
dbeb78e
feat(VolumeCroppingControlTool): trigger event on tool state change
mbellehumeur Jul 23, 2025
0d47eb3
Add frameOfReference to tool events so that many tool instances can r…
mbellehumeur Jul 24, 2025
a5f5aae
feat(VolumeCroppingTool): use seriesInstanceUID instead of frameOfRe…
mbellehumeur Jul 25, 2025
7ca49ce
feat(VolumeCroppingTool): enhance documentation for VolumeCroppingToo…
mbellehumeur Jul 25, 2025
bb61f8c
feat(VolumeCroppingTool): update sphere color properties and add visi…
mbellehumeur Jul 25, 2025
e51df99
fix(VolumeCroppingControlTool): remove unused seriesInstanceUID from …
mbellehumeur Jul 25, 2025
4817370
feat(VolumeCroppingTool): improve handle visibility logic when changi…
mbellehumeur Jul 25, 2025
b36dedd
refactor(VolumeCroppingTool): streamline VTK pipeline update logic an…
mbellehumeur Jul 25, 2025
dc09fd0
fix(VolumeCroppingTool): conditionally set clipping plane origin base…
mbellehumeur Jul 25, 2025
517af4c
fix(VolumeCroppingTool): update clipping plane origin condition to ch…
mbellehumeur Jul 25, 2025
d51f3ef
refactor(VolumeCroppingTool): remove VTK update logic (real problem …
mbellehumeur Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading