fix(WindowLevelTool): fix calculation of image dynamic range - #2147
Merged
Conversation
sedghi
reviewed
Jun 16, 2025
sedghi
left a comment
Member
There was a problem hiding this comment.
is this just fixing our types?
Contributor
Author
No, it's fixing the calculation. Sorry the description might have been confusing. |
Member
|
can you see why unit test failing? |
Contributor
Author
There is a diff in some |
Contributor
Author
|
Updated the ground truth window level image. |
Contributor
Author
|
@sedghi tests are passing now. |
sedghi
approved these changes
Jul 9, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There is a type error in the calculation of the image dynamic range in the WindowLevelTool, which leads to a wrong multiplier.
Changes & Results
Fix calculation of image dynamic range in WindowLevelTool.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment