feat: enable historyMemo action grouping - #2160
Conversation
|
Is there one of the CS3D examples that can demonstrate this? I'd prefer to test/display directly within CS3D |
|
@sedghi - I'm off next week, but the changes look ok, I just want to see an example in CS3D so that I can play with it/test it as a combined set. |
|
@wayfarer3130 done. Added a new example so that you can play with it. |
|
@pedrokohler - I found a bug in this related to the preview mode:
The first undo marks the segmentations as in preview mode, while the second one marks the original segmentation as in preview mode additionally, but doesn't remove the segmentations after the group recording. Compaer with/without the group recording. |
wayfarer3130
left a comment
There was a problem hiding this comment.
Can you fix the one bug I found and address the asArray issue - the asArray can go in cs3d core utilities since that type of code gets executed all over the place.
* feat: enable historyMemo action grouping * feat: add tool history grouping example * feat: add asArray function * fix: preview bug * chore: add jsdocs to asArray
…redo CEN-15883 - enable historyMemo action grouping (cornerstonejs#2160)
Context
Currently, if you have a batch of actions, such as clearing multiple annotations at once, cornerstone is not capable of track that and undo/redo these batched actions.
This PR introduces an api of start/end recording, which will enable consumer apps to group actions that are related.
Changes & Results
Example of Before/After with OHIF
Before:
Screenshare.-.2025-06-26.9_06_40.AM.mp4
After:
Screenshare.-.2025-06-26.9_04_40.AM.mp4
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment