feat: add segmentLabel color - #2169
Merged
sedghi merged 2 commits intoJul 8, 2025
Merged
Conversation
Contributor
Author
|
@sedghi can you take a look? |
Member
|
I'm not sure why is there a link (line) svg, isn't it suppose to be on the mouse (like right side of it?) |
Contributor
Author
@sedghi I removed the link and left just the text now. Check out the new image in the PR description. |
Member
|
let me try |
Member
|
I tried it works great with smaller hoverTimeouts, any reason not to have a lower default like 1 even? |
Contributor
Author
|
@sedghi I just copied the other tool, the SegmentSelect one. Feel free to change the default timeout to whatever value you like and merge. |
sedghi
approved these changes
Jul 7, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Using the same segment color with the segmentLabel tool as requested here: OHIF/Viewers#5164 (comment)
Related to OHIF/Viewers#4600
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment