Skip to content

feat: add segmentLabel color - #2169

Merged
sedghi merged 2 commits into
cornerstonejs:mainfrom
pedrokohler:feat-add-segment-label-color
Jul 8, 2025
Merged

feat: add segmentLabel color#2169
sedghi merged 2 commits into
cornerstonejs:mainfrom
pedrokohler:feat-add-segment-label-color

Conversation

@pedrokohler

@pedrokohler pedrokohler commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Context

Using the same segment color with the segmentLabel tool as requested here: OHIF/Viewers#5164 (comment)

Related to OHIF/Viewers#4600

Changes & Results

image

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@pedrokohler

Copy link
Copy Markdown
Contributor Author

@sedghi can you take a look?

@sedghi

sedghi commented Jul 3, 2025

Copy link
Copy Markdown
Member

I'm not sure why is there a link (line) svg, isn't it suppose to be on the mouse (like right side of it?)

@pedrokohler

Copy link
Copy Markdown
Contributor Author

I'm not sure why is there a link (line) svg, isn't it suppose to be on the mouse (like right side of it?)

@sedghi I removed the link and left just the text now. Check out the new image in the PR description.

@sedghi

sedghi commented Jul 7, 2025

Copy link
Copy Markdown
Member

let me try

@sedghi

sedghi commented Jul 7, 2025

Copy link
Copy Markdown
Member

I tried it works great with smaller hoverTimeouts, any reason not to have a lower default like 1 even?

@pedrokohler

Copy link
Copy Markdown
Contributor Author

@sedghi I just copied the other tool, the SegmentSelect one.

Feel free to change the default timeout to whatever value you like and merge.

@sedghi
sedghi merged commit 1023632 into cornerstonejs:main Jul 8, 2025
9 checks passed
@sedghi sedghi mentioned this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants