Skip to content

fix(segmentation): replace unbounded render queue with coalescing Set #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pedrokohler wants to merge 1 commit into from
+6 −7
Closed

fix(segmentation): replace unbounded render queue with coalescing Set #2674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/tools/src/stateManagement/segmentation/SegmentationRenderingEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const planarContourToolName = PlanarFreehandContourSegmentationTool.toolName;
*/
class SegmentationRenderingEngine {
private _needsRender: Set<string> = new Set();
private _pendingRenderQueue: string[][] = [];
private _pendingRender: Set<string> = new Set();
private _animationFrameSet = false;
private _animationFrameHandle: number | null = null;
public hasBeenDestroyed: boolean;
Expand Down Expand Up @@ -121,7 +121,7 @@ class SegmentationRenderingEngine {
private _setViewportsToBeRenderedNextFrame(viewportIds: string[]) {
if (this._animationFrameSet) {
// If a render is already scheduled, queue this set for after the current one
this._pendingRenderQueue.push(viewportIds);
viewportIds.forEach((id) => this._pendingRender.add(id));
return;
}
// Add the viewports to the set of flagged viewports
Expand Down Expand Up @@ -165,11 +165,10 @@ class SegmentationRenderingEngine {
this._animationFrameHandle = null;

// If there are pending viewportId sets, schedule the next one
if (this._pendingRenderQueue.length > 0) {
const nextViewportIds = this._pendingRenderQueue.shift();
if (nextViewportIds && nextViewportIds.length > 0) {
this._setViewportsToBeRenderedNextFrame(nextViewportIds);
}
if (this._pendingRender.size > 0) {
const nextViewportIds = Array.from(this._pendingRender);
this._pendingRender.clear();
this._setViewportsToBeRenderedNextFrame(nextViewportIds);
}
};

Expand Down
Loading