Fix(lengthtool) autodelete#2708
Open
bionoone wants to merge 2 commits into
Open
Conversation
sedghi
reviewed
Apr 24, 2026
| @@ -1 +1 @@ | |||
| yarn lint-staged | |||
| bun lint-staged | |||
110c404 to
67b34dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
in commit 20efd77#diff-4bdf7112153ce30f1829f12a4e4899bcf36b964d578c23c5c0e82235f8e166f3
there is a change in convertion from transformWorldToIndex that perform a integer index conversion in favor of imageData.worldToIndex that perform continuous index conversion.
This has an impact on annotation drawn on stack viewport, where z extend is from 0 to 1.
due to conversion, the z coordinate could become something -1e-5 leading to some side effect when preventHandleOutsideImage option is on.
Changes & Results
added a tollerance of EPSILON in new method indexAlmostWithinDimensions
Testing
add karma test exhibiting the defect
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment