Skip to content

feat: upgrade to vtk.js 36.x#2750

Open
daker wants to merge 1 commit into
cornerstonejs:mainfrom
daker:upgrade-vtkjs3611
Open

feat: upgrade to vtk.js 36.x#2750
daker wants to merge 1 commit into
cornerstonejs:mainfrom
daker:upgrade-vtkjs3611

Conversation

@daker

@daker daker commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Context

Changes & Results

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS:
  • "Node version:
  • "Browser:

Summary by CodeRabbit

  • Chores
    • Updated the core visualization library dependency to a newer version, bringing performance improvements and enhanced stability across all modules.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ea219ab2-56ca-4f3c-a492-d5ae50e4dcdc

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7ce81 and a76b47e.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • packages/core/package.json
  • packages/labelmap-interpolation/package.json
  • packages/polymorphic-segmentation/package.json
  • packages/tools/package.json

📝 Walkthrough

Walkthrough

This PR updates the @kitware/vtk.js dependency version from 34.15.1 to 36.1.1 consistently across four package manifests in the monorepo: core, labelmap-interpolation, polymorphic-segmentation, and tools packages.

Changes

VTK.js Version Bump

Layer / File(s) Summary
VTK.js version upgrade across packages
packages/core/package.json, packages/labelmap-interpolation/package.json, packages/polymorphic-segmentation/package.json, packages/tools/package.json
All four packages update @kitware/vtk.js from 34.15.1 to 36.1.1 consistently across dependencies and peerDependencies.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 Four packages hop forward bright,
VTK.js makes the version flight,
From 34 to 36 we climb,
A synchronized, harmonious time!
🚀✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description follows the repository template structure with checklist items marked complete, but the Context, Changes & Results, and Testing sections lack substantive details—containing only template comments without actual information about the upgrade's rationale, effects, or validation. Add specific details to Context (issue link or rationale for upgrade), Changes & Results (compatibility notes, breaking changes if any), and Testing (verification steps performed). Consider documenting which versions were tested and any known issues.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: upgrade to vtk.js 36.x' clearly and concisely describes the main change—upgrading the @kitware/vtk.js dependency from 34.15.1 to 36.1.1 across multiple packages, following semantic-release format conventions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@daker

daker commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

@sedghi not sure what to do to make pass the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant