Skip to content

fix(wsi): correct point annotation placement on SM/WSI viewports at n… #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedghi merged 3 commits into from
Jul 8, 2026
+2 −6
Merged

fix(wsi): correct point annotation placement on SM/WSI viewports at n… #2769

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cc9ce9
fix(wsi): correct point annotation placement on SM/WSI viewports at n…
Jun 24, 2026
3897eb1
Merge remote-tracking branch 'origin/main' into pr-2769-sync
sedghi Jul 8, 2026
5119446
Merge remote-tracking branch 'origin/main' into pr-2769-sync
sedghi Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/core/src/RenderingEngine/WSIViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,17 +696,13 @@ class WSIViewport extends Viewport {
protected canvasToIndex = (canvasPos: Point2): Point3 => {
const transform = this.getTransform();
transform.invert();
const indexPoint = transform.transformPoint(
canvasPos.map((it) => it * devicePixelRatio) as Point2
);
const indexPoint = transform.transformPoint(canvasPos);
return [indexPoint[0], indexPoint[1], 0] as Point3;
};

protected indexToCanvas = (indexPos: Point3): Point2 => {
const transform = this.getTransform();
return transform
.transformPoint([indexPos[0], indexPos[1]])
.map((it) => it / devicePixelRatio) as Point2;
return transform.transformPoint([indexPos[0], indexPos[1]]);
};

/** This can be implemented later when multi-slice WSI is supported */
Expand Down
Loading