Skip to content

fix(wsi): render WSIViewport via setDisplaySets by resolving the registered generic dataset #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbocce wants to merge 2 commits into from
Closed

fix(wsi): render WSIViewport via setDisplaySets by resolving the registered generic dataset #2774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b6e76
fix(wsi): render WSIViewport via setDisplaySets by resolving the regi…
jbocce Jun 27, 2026
e0e67d9
PR feedback.
jbocce Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/core/src/RenderingEngine/WSIViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
type WSITransformUtilitiesLike,
type WSIViewerLike,
} from '../utilities/WSIUtilities';
import { getGenericViewportWSIDataSet } from './GenericViewport/genericViewportDataSetAccess';

let WSIUtilFunctions: WSITransformUtilitiesLike | null = null;
const EVENT_POSTRENDER = 'postrender';
Expand Down Expand Up @@ -626,6 +627,33 @@ class WSIViewport extends Viewport {
});
}

/**
* Renders a registered whole-slide display set. The dataset (imageIds +
* webClient) must first be registered with
* `utilities.genericViewportDataSetMetadataProvider` keyed by `displaySetId`.
* This reads from the same registry as the GenericViewport WSI data provider,
* so the same caller code drives both the legacy and generic render paths.
*/
public async setDisplaySets(

@sedghi sedghi Jun 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should come with the other set display sets big PR with documentation

...entries: Array<{ displaySetId: string; options?: unknown }>
): Promise<void> {
const [entry] = entries;
if (!entry?.displaySetId) {
throw new Error(
'[WSIViewport] setDisplaySets requires a displaySetId to render whole slide imaging'
);
}

const dataSet = getGenericViewportWSIDataSet(entry.displaySetId);
if (!dataSet?.imageIds?.length || !dataSet.options?.webClient) {
throw new Error(
`[WSIViewport] No registered WSI dataset (imageIds + webClient) for display set ${entry.displaySetId}`
);
}

return this.setDataIds(dataSet.imageIds, dataSet.options);
}

public postrender = () => {
this.refreshRenderValues();
triggerEvent(this.element, EVENTS.IMAGE_RENDERED, {
Expand Down
Loading