improve findings by Fable#2787
Draft
sedghi wants to merge 2 commits into
Draft
Conversation
13 self-contained implementation plans from a code audit of main at b4c094e: correctness fixes (cancelLoadAll, Synchronizer listener leaks, VideoViewport teardown, cache lookup/budget, StackViewport CPU promise, VolumeCroppingTool leak), performance (bounded segmentation stats payloads, WholeBodySegmentTool island scan), and CI hardening (typecheck gate, oxlint expansion, decompress advisory override, cross-browser Playwright lane).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
plans/directory with the findings from a code audit ofmainatb4c094e92(2026-07-07) and 13 self-contained implementation plans, one per selected finding.plans/README.mdis the index: execution order, dependency graph, status table, the confirmed-but-unplanned backlog, and a considered-and-rejected list so items don't get re-audited.Every finding was verified against the code (file:line evidence in each plan). Each plan carries current-state excerpts, exact verification commands, scope boundaries, a test plan, and STOP conditions — written so an executor with zero context from the audit can implement it.
Plans
cancelLoadAllcalling nonexistent.cancel()instead ofcancelFngetVolumeContainingImageIdaborting on the first empty/unloaded volumeawait setImageIdIndex)VideoViewport.elementDisabledHandlerso video teardown runspurgeCache()boundsIJKcorrectnesscategory (ratcheted)decompresscritical advisory (GHSA-w7fw-mjwx-w883) via pnpm overridesRecommended order: 010 first (verification baseline), then 001–006 (independent), 007 after 002 (same file), 011 after 010, 008→009, 013 last.
Notes
RenderingEngine/GenericViewport/**(separately reviewed), examples, and the in-progress legacy-viewport migration.Audit and plans produced with Claude (Fable).