Skip to content

fix(security): update dependencies to fix security vulnerabilities OHIF-2682 #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbocce merged 1 commit into from
Jul 23, 2026
+4,379 −12,280
Merged

fix(security): update dependencies to fix security vulnerabilities OHIF-2682 #2822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"@types/node": "20.17.24",
"@types/react": "17.0.83",
"@types/react-dom": "17.0.26",
"@vitest/browser-playwright": "4.1.8",
"@vitest/browser-playwright": "4.1.10",

@coderabbitai coderabbitai Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json relevant lines =="
sed -n '85,102p;160,172p' package.json

echo
echo "== lockfile vitest entries (sample) =="
awk '
  "/node_modules/vitest@/ || /node_modules\/@vitest\/browser-playwright@/ {p=1}
   p && /^  [^ ]/ {exit}
   p {print NR": "$0}
' pnpm-lock.yaml | sed -n '1,120p'

echo
echo "== search exact peer deps for `@vitest/browser-playwright` =="
python3 - <<'PY'
import json, re, pathlib
pkg=json.loads(pathlib.Path('package.json').read_text())
for sec in ('dependencies','devDependencies','optionalDependencies','peerDependencies'):
    print(sec, pkg.get(sec,{}).get('`@vitest/browser-playwright`'), pkg.get(sec,{}).get('vitest'))
PY

echo
echo "== fetch official package manifests =="
python3 - <<'PY'
import json, urllib.request
for name, ver in [('vitest','4.1.8'),('`@vitest/browser-playwright`','4.1.10'),('`@vitest/browser-playwright`','4.1.9')]:
    url=f'https://registry.npmjs.org/{name}/-/'+name+'-'+ver+'.tgz'
    try:
        data=urllib.request.urlopen(url, timeout=20).read()
        import tarfile, io
        with tarfile.open(fileobj=io.BytesIO(data), mode='r:gz') as tf:
            pm=tf.extractfile(tf.getnames()[0][:-9]+'package.json')
            pkg=json.load(pm)
        print(name+' @'+ver)
        for k in ('version','files','dependencies','devDependencies','peerDependencies','peerDependenciesMeta'):
            v=pkg.get(k)
            if isinstance(v, (dict,str,list)) and v and k != 'files':
                print(f'  {k}: {json.dumps(v, ensure_ascii=False, indent=2)[:800]}')
    except Exception as e:
        print(name+' @'+ver + ': ERROR ' + str(e))
PY

Repository: cornerstonejs/cornerstone3D

Length of output: 1333

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json relevant lines =="
sed -n '85,102p;160,172p' package.json

echo
echo "== lockfile vitest entries (sample) =="
awk '
  "/node_modules/vitest@/ || /node_modules\/@vitest\/browser-playwright@/ {p=1}
   p && /^  [^ ]/ {exit}
   p {print NR": "$0}
' pnpm-lock.yaml | sed -n '1,120p'

echo
echo "== search exact peer deps for `@vitest/browser-playwright` =="
python3 - <<'PY'
import json, re, pathlib
pkg=json.loads(pathlib.Path('package.json').read_text())
for sec in ('dependencies','devDependencies','optionalDependencies','peerDependencies'):
    print(sec, (pkg.get(sec,{}).get('`@vitest/browser-playwright`'), pkg.get(sec,{}).get('vitest')))
PY

echo
echo "== fetch official package manifests =="
python3 - <<'PY'
import json, urllib.request
for name, ver in [('vitest','4.1.8'),('`@vitest/browser-playwright`','4.1.10'),('`@vitest/browser-playwright`','4.1.9')]:
    url=f'https://registry.npmjs.org/{name}/-/'+name+'-'+ver+'.tgz'
    try:
        data=urllib.request.urlopen(url, timeout=20).read()
        import tarfile, io
        with tarfile.open(fileobj=io.BytesIO(data), mode='r:gz') as tf:
            pm=tf.extractfile(tf.getnames()[0][:-9]+'package.json')
            pkg=json.load(pm)
        print(name+' @'+ver)
        for k in ('version','dependencies','devDependencies','peerDependencies','peerDependenciesMeta'):
            v=pkg.get(k)
            if isinstance(v, (dict,str,list)) and v and k != 'files':
                print(f'  {k}: {json.dumps(v, ensure_ascii=False)[:1200]}')
    except Exception as e:
        print(name+' @'+ver + ': ERROR ' + str(e))
PY

Repository: cornerstonejs/cornerstone3D

Length of output: 1333

Keep the Vitest packages on the same patch version.

vitest is still 4.1.8 while @vitest/browser-playwright is 4.1.10; align vitest to 4.1.10 and regenerate pnpm-lock.yaml so browser tests do not run with mixed Vitest package versions.

Proposed fix 
-    "vitest": "4.1.8",
+    "vitest": "4.1.10",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 96, Align the package.json vitest dependency with
`@vitest/browser-playwright` at version 4.1.10, then regenerate pnpm-lock.yaml so
all Vitest packages resolve to the same patch version.

"@webgpu/types": "0.1.56",
"acorn": "8.14.1",
"acorn-jsx": "5.3.2",
Expand Down
Loading
Loading